Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reusable sanitary Pads #78

Merged
merged 11 commits into from
Oct 17, 2023
Merged

Reusable sanitary Pads #78

merged 11 commits into from
Oct 17, 2023

Conversation

dawaedina27
Copy link

No description provided.

@dawaedina27 dawaedina27 marked this pull request as ready for review October 13, 2023 11:37
timmwille
timmwille requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@timmwille timmwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good draft, I made some suggestions to improve the code. Also consider adding another resource that introduces the topic (an external video, or article or something you created yourself describing the background/context and importance?)

_modules/Reusable_Sanitary_Pads.md Outdated Show resolved Hide resolved
_modules/Reusable_Sanitary_Pads.md Outdated Show resolved Hide resolved
_modules/Reusable_Sanitary_Pads.md Outdated Show resolved Hide resolved
_resources/reusable_sanitary_pads.md Outdated Show resolved Hide resolved
_modules/Reusable_Sanitary_Pads.md Outdated Show resolved Hide resolved
@timmwille timmwille changed the base branch from main to development October 13, 2023 12:48
timmwille
timmwille approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@timmwille timmwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval from my end @walthierer

@dawaedina27
Copy link
Author

Thanks @timmwille

@timmwille timmwille mentioned this pull request Oct 17, 2023
Closed
@timmwille timmwille merged commit e016667 into ASKnetCommunity:development Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmwille timmwille timmwille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dawaedina27 @timmwille @walthierer