perf: redundant updateTransform() call removed

ASGAlex · Oct 21, 2023 · 03b1972 · 03b1972
1 parent cdb7caa
commit 03b1972
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/example/lib/game.dart b/example/lib/game.dart
@@ -121,7 +121,7 @@ all collisions are disabled.
       buildCellsPerUpdate: buildCellsPerUpdate,
       cleanupCellsPerUpdate: cleanupCellsPerUpdate,
       suspendedCellLifetime: const Duration(minutes: 10),
-      scheduledLayerOperationLimit: 5,
+      scheduledLayerOperationLimit: 1,
       cellBuilderNoMap: noMapCellBuilder,
       maps: [
         DemoMapLoader(Vector2(600, 0)),

diff --git a/lib/src/collisions/collision_detection.dart b/lib/src/collisions/collision_detection.dart
@@ -60,7 +60,7 @@ class SpatialGridCollisionDetection
       _listenerCollisionType[item] = listenerCollisionType;
 
       item.defaultCollisionType; //init defaults with current value;
-      withGridSupportComponent.updateTransform();
+      _scheduledUpdateAfterTransform.add(item);
 
       broadphase.updateHitboxIndexes(item);
       final componentCurrentCell = withGridSupportComponent.currentCell;

diff --git a/lib/src/collisions/hitboxes/bounding_hitbox.dart b/lib/src/collisions/hitboxes/bounding_hitbox.dart
@@ -28,7 +28,7 @@ typedef BoundingHitboxFactory = BoundingHitbox Function();
 /// [SpatialGridRectangleHitbox] and [SpatialGridShapeHitbox] extensions
 /// provides same functionality for pure Flame hitboxes
 class BoundingHitbox extends RectangleHitboxOptimized
-    with HasGameRef<HasSpatialGridFramework>
+    with HasGameReference<HasSpatialGridFramework>
     implements MacroObjectInterface {
   BoundingHitbox({
     super.position,

diff --git a/lib/src/components/has_grid_support.dart b/lib/src/components/has_grid_support.dart
@@ -350,10 +350,13 @@ mixin HasGridSupport on PositionComponent implements MacroObjectInterface {
     if (spatialGrid == null) {
       return;
     }
-    boundingBox.aabbCenter = boundingBox.aabb.center;
-    cachedCenters.remove(boundingBox);
-    final componentCenter = boundingBox.aabbCenter;
+    final componentCenter = boundingBox.aabbCenter =
+        cachedCenters[boundingBox] = boundingBox.aabb.center;
     var current = currentCell;
+    if (kDebugMode && current == null) {
+      print('better to set currentCell manually. Component: $runtimeType');
+    }
+
     List<Cell?>? previousCellNeighbours;
     current ??= spatialGrid.findExistingCellByPosition(componentCenter) ??
         spatialGrid.createNewCellAtPosition(componentCenter);