docs: drop removed pr_number input from apply.yml dispatch example - #439
Open
Svaag wants to merge 1 commit into
Open
docs: drop removed pr_number input from apply.yml dispatch example#439Svaag wants to merge 1 commit into
Svaag wants to merge 1 commit into
Conversation
The deploy runbook still showed `gh workflow run apply.yml -F pr_number=42` and a "/ PR" UI hint, but the `pr_number` input was removed from apply.yml in #432 (and the last stale caller fixed in #437). Running that command now errors on an unexpected input. Drop the flag and the UI hint so the example matches apply.yml's current inputs (playbook / limit / dry_run). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #437. Grepping the repo for stale
apply.ymlpr_numbercallers(the input was removed in #432) turned up one last reference — a doc example,
not a workflow caller:
docs/ci/deploy-runbook.mdshowed:gh workflow run apply.yml \ -F playbook=noc -F limit=noc -F dry_run=false \ -F pr_number=42 # optional — auto-comments the diff onto the PRRunning that today errors on an unexpected input. Removed the flag and the
matching "/ PR" UI hint so the runbook matches
apply.yml's current inputs(
playbook/limit/dry_run).Verification
grep -rn pr_numberacross the repo now returns zero references — noworkflow callers (only
app-promotion-deploy.ymlcallsapply.yml, fixed in#437) and no docs.
🤖 Generated with Claude Code