Skip to content

docs: drop removed pr_number input from apply.yml dispatch example - #439

Open
Svaag wants to merge 1 commit into
mainfrom
fix/deploy-runbook-pr-number
Open

docs: drop removed pr_number input from apply.yml dispatch example#439
Svaag wants to merge 1 commit into
mainfrom
fix/deploy-runbook-pr-number

Conversation

@Svaag

@Svaag Svaag commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

What

Follow-up to #437. Grepping the repo for stale apply.yml pr_number callers
(the input was removed in #432) turned up one last reference — a doc example,
not a workflow caller:

docs/ci/deploy-runbook.md showed:

gh workflow run apply.yml \
  -F playbook=noc -F limit=noc -F dry_run=false \
  -F pr_number=42         # optional — auto-comments the diff onto the PR

Running that today errors on an unexpected input. Removed the flag and the
matching "/ PR" UI hint so the runbook matches apply.yml's current inputs
(playbook / limit / dry_run).

Verification

grep -rn pr_number across the repo now returns zero references — no
workflow callers (only app-promotion-deploy.yml calls apply.yml, fixed in
#437) and no docs.

🤖 Generated with Claude Code

The deploy runbook still showed `gh workflow run apply.yml -F pr_number=42` and a
"/ PR" UI hint, but the `pr_number` input was removed from apply.yml in #432 (and
the last stale caller fixed in #437). Running that command now errors on an
unexpected input. Drop the flag and the UI hint so the example matches apply.yml's
current inputs (playbook / limit / dry_run).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Svaag
Svaag requested a review from a team as a code owner July 12, 2026 15:56
@github-actions

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

437 - Partially compliant

Compliant requirements:

  • None. The PR does not touch workflow files; it only updates a documentation example.

Non-compliant requirements:

  • Does not remove pr_number from firewall job in app-promotion-deploy.yml.
  • Does not fix the workflow startup failure.

432 - Partially compliant

Compliant requirements:

  • Removes a stale pr_number reference from docs/ci/deploy-runbook.md doc example.

Non-compliant requirements:

  • Does not remove the Icinga deploy-snapshot mechanism from playbooks, roles, or configs.
  • Does not modify apply.yml or app-promotion-deploy.yml workflow files.
  • Does not delete test scripts or CI hooks.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 95
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant