Skip to content

[codex] Document NOC BGP snapshot retention#336

Merged
Svaag merged 1 commit into
mainfrom
docs/noc-bgp-snapshot-retention
Jul 1, 2026
Merged

[codex] Document NOC BGP snapshot retention#336
Svaag merged 1 commit into
mainfrom
docs/noc-bgp-snapshot-retention

Conversation

@Svaag

@Svaag Svaag commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Scope

Validation

  • Not run; docs-only change.

Related

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit e0e643a)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

321 - Partially compliant

Compliant requirements:

  • PR summary includes incident root cause and manual mitigation.

Non-compliant requirements:

  • Ansible ownership of timer/service not implemented.
  • Retention enforcement not implemented.
  • Retention horizon not yet configured in Ansible.
  • Idempotency of playbook not verified by this change.
  • Post-apply checks not performed by this PR.

Requires further human verification:

  • After apply checks (timer active, cleanup, free space, apt-get update) require deployment verification.

300 - Partially compliant

Compliant requirements:

(empty)

Non-compliant requirements:

  • None of the acceptance criteria are addressed by this documentation-only PR.

Requires further human verification:

  • All criteria require the operational fix and monitoring changes, not assessable via this docs PR.

299 - Partially compliant

Compliant requirements:

(empty)

Non-compliant requirements:

  • None of the acceptance criteria are addressed by this documentation-only PR.

Requires further human verification:

  • All criteria require the operational fix and monitoring changes, not assessable via this docs PR.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 85
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@Svaag Svaag marked this pull request as ready for review July 1, 2026 02:59
@Svaag Svaag requested a review from a team as a code owner July 1, 2026 02:59
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit e0e643a

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@Svaag Svaag merged commit 896c9ff into main Jul 1, 2026
12 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e0e643a1f5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

After applying the `noc` playbook:

```bash
ansible-playbook ansible/playbooks/noc.yml --tags apply \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Run the NOC playbook from ansible/

This verification command is written for the repo root, but Ansible does not load ansible/ansible.cfg based on the playbook path; the documented config precedence is ANSIBLE_CONFIG, then ansible.cfg in the current directory. From the repo root that skips this repo's ansible/ansible.cfg (inventory = ./inventory/hosts.yml, roles_path = ./roles), so the playbook will not resolve the noc inventory and local roles reliably. Please cd ansible and use playbooks/noc.yml, or set ANSIBLE_CONFIG=ansible/ansible.cfg. See the Ansible config docs: https://docs.ansible.com/projects/ansible/latest/reference_appendices/config.html#the-configuration-file

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent noc BGP router snapshots from filling root filesystem

1 participant