Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the production api inventory still setting
hyrule_cloud_monero_wallet_rpc_enabled: true(ansible/inventory/host_vars/api.yml:5), this env-only relaxation does not remove the apply-time dependency on the failed wallet RPC. Thecloudapply importsvault.ymlbeforehealth.yml, andvault.ymlstill runsstate: startedformonero-wallet-rpc.servicewhen that flag is true (ansible/roles/hyrule_cloud/tasks/vault.yml:148-154), so in the exact incident described here (invalid wallet password/ringdb permission causing the service not to start) the production apply can fail before the post-deploy health check rather than completing the restore; also disable/bypass that service or make it non-blocking whilePAYMENT_REQUIRE_NATIVE=false.Useful? React with 👍 / 👎.