Add msplim_ns for box 0 #520
Conversation
|
please review @danny4478 @alzix @romkuz01 |
api/src/uvisor-input.S
Outdated
| @@ -114,6 +114,9 @@ uvisor_config: | |||
| /* Debug driver pointer */ | |||
| .long __uvisor_debug_driver | |||
|
|
|||
| /* Stack limit for MSPNS_LIM */ | |||
There was a problem hiding this comment.
Change MSPNS_LIM to MSPLIM_NS in the comment.
core/system/inc/linker.h
Outdated
| @@ -121,6 +121,9 @@ typedef struct { | |||
| UvisorLibHooks const * const lib_hooks; | |||
|
|
|||
| TUvisorDebugDriver const * const debug_driver; | |||
|
|
|||
| /* Stack limit for MSPNS_LIM */ | |||
There was a problem hiding this comment.
Change MSPNS_LIM to MSPLIM_NS in the comment.
api/src/uvisor-input.S
Outdated
| @@ -114,6 +114,9 @@ uvisor_config: | |||
| /* Debug driver pointer */ | |||
| .long __uvisor_debug_driver | |||
|
|
|||
| /* Stack limit for MSPLIM_NS */ | |||
| .long __uvisor_stack_limit | |||
There was a problem hiding this comment.
IMHO the variable name is misleading as it holds not the uvisor stack limit but the public box stack limit.
Am i missing something?
core/system/inc/linker.h
Outdated
| @@ -121,6 +121,9 @@ typedef struct { | |||
| UvisorLibHooks const * const lib_hooks; | |||
|
|
|||
| TUvisorDebugDriver const * const debug_driver; | |||
|
|
|||
| /* Stack limit for MSPLIM_NS */ | |||
| uint32_t * stack_limit; | |||
There was a problem hiding this comment.
- same here what stack limit is it used for?
- Additional question - what will we do with this new field on ARMv7-M platforms?
- Please note the naming conventions here - members are named exactly as in the
uvisor-input.Sexcept__uvisor_prefix
api/src/uvisor-input.S
Outdated
| @@ -114,6 +114,9 @@ uvisor_config: | |||
| /* Debug driver pointer */ | |||
| .long __uvisor_debug_driver | |||
|
|
|||
| /* Stack limit for MSPLIM_NS */ | |||
| .long __uvisor_stack_limit | |||
|
|
|||
There was a problem hiding this comment.
i see you are missing the assignment here as you have assigned the value to the __uvisor_stack_limit from the mbed-os linker script.
Please consider assigning StackLimit symbol directly without intermediate variable and without modifying mbed-os sources.
|
@Patater - please approve |
api/src/uvisor-input.S
Outdated
| @@ -114,6 +114,9 @@ uvisor_config: | |||
| /* Debug driver pointer */ | |||
| .long __uvisor_debug_driver | |||
|
|
|||
| /* Stack limit for publix box MSPLIM_NS, accessed by public_box_stack_limit */ | |||
api/src/uvisor-input.S
Outdated
| @@ -134,6 +137,9 @@ __uvisor_debug_driver: | |||
| .long 0 | |||
| .long 0 | |||
|
|
|||
| __uvisor_public_box_stack_limit: | |||
| .long __StackLimit | |||
There was a problem hiding this comment.
Why do we need the public box stack limit twice? Why not just put __StackLimit where __uvisor_public_box_stack_limit is instead?
theamirocohen
force-pushed
the
msplim
branch
2 times, most recently
from
3be273a
to
40e06f7
Compare
|
/morph uvisor-test |
requies changes from PR ARMmbed/mbed-os#5321
and changes from #486
and #496