Wrap thread_switch in an atomic section #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system hook thread_switch gets called both through the SVC and though the PendSV, which can get interrupted by the SVC. Since calls to the uVisor API are not re-entrant, we need to wrap this function in an atomic section to prevent faults.
AlessandroA
reviewed
Sep 23, 2016
| /* Wrap a function call into an atomic section with IRQ state restoration. */ | ||
| #define atomic_call_wrapper(fn) { \ | ||
| uint32_t primask = __get_PRIMASK(); \ | ||
| __disable_irq(); \ |
There was a problem hiding this comment.
What happens when this is called from an SVC?
There was a problem hiding this comment.
In that case the atomic section would not be necessary, but it also doesn't do any harm.
| @@ -27,6 +27,16 @@ | |||
| #include "halt.h" | |||
| #include "vmpu.h" | |||
|
|
|||
| /* Wrap a function call into an atomic section with IRQ state restoration. */ | |||
| #define atomic_call_wrapper(fn) { \ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system hook thread_switch gets called both through the SVC and
though the PendSV, which can get interrupted by the SVC.
Since calls to the uVisor API are not re-entrant, we need to wrap this
function in an atomic section to prevent faults.
cc @AlessandroA @meriac @Patater