Implement g_nvic_prio_bits for UVISOR_DISABLED #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When __uvisor_mode is UVISOR_DISABLED the NVIC APIs are used instead of the vIRQ ones. Now that those APIs are pre-compiled into a library, the NVIC APIs use the uVisor built-in definitions from cmsis/core_generic.h. In that file __NVIC_PRIO_BITS is re-defined as a global variable which is evaluated at start-up. This behaviour has now been mirrored to the case of disabled uVisor. Warning: This is a workaround. Applications that are written following the uVisor guidelines for the use of vIRQ APIs will work without problems: > The vIRQ_SetVector must be used before any other vIRQ API for any given IRQn slot. While this is currently the case for all mbed OS code, it is not guaranteed to work with new code. For example, if vIRQ_SetPriority is called before vIRQ_SetVector unpredictable behaviour will follow. This issue will be fixed by a more generalized approach to disabled uVisor.
AlessandroA
force-pushed
the
g_nvic_prio
branch
from
30d415d to
166cff3
Compare
meriac
added a commit
that referenced
this pull request
Mar 18, 2016
Implement g_nvic_prio_bits for UVISOR_DISABLED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When __uvisor_mode is UVISOR_DISABLED the NVIC APIs are used instead of
the vIRQ ones. Now that those APIs are pre-compiled into a library, the
NVIC APIs use the uVisor built-in definitions from cmsis/core_generic.h.
In that file __NVIC_PRIO_BITS is re-defined as a global variable which
is evaluated at start-up. This behaviour has now been mirrored to the
case of disabled uVisor.
@meriac @Patater
Note: This was previously in a previous PR.