Skip to content

Remove pyocd requirement and update icetea. #9740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

bridadan
Copy link
Contributor

Description

This change was prompted by the concerns raised here: #9481 (comment). This removes pyocd from Mbed OS's tools requirements.

Icetea depends on mbed-flasher. mbed-flasher recently released a version
that drops the dependency on pyocd. Icetea released a version that uses
this latest version of mbed-flasher. So now that pyocd is no longer in
our dependency tree, we can drop it here.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

Icetea depends on mbed-flasher. mbed-flasher recently released a version
that drops the dependency on pyocd. Icetea released a version that uses
this latest version of mbed-flasher. So now tht pyocd is no longer in
our dependency tree, we can drop it here.
@bridadan bridadan requested a review from cmonr February 15, 2019 15:07
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less dependencies, better :-)

@bridadan
Copy link
Contributor Author

@ChiefBureaucraticOfficer has requested this to land for 5.11.5

@cmonr
Copy link
Contributor

cmonr commented Feb 15, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 15, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Feb 15, 2019

Restarted export since failure seems unrelated to PR.

@cmonr cmonr merged commit 3a301cd into ARMmbed:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants