Travis: testing astyle job failures #9336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xc0170, thank you for your changes. |
|
@cmonr This fails as expected (reproduced on another PR targeting a branch instead of master). We should rather use variables travis provides? https://docs.travis-ci.com/user/environment-variables/
|
...and revert depth change.
Travis CI does not pull the base branch, only the last 50 commits. This is fine for PRs targeting master, but fails when PRs for feature branches come in.
Doing the fetch was overriding the original `git fetch`, and would prefer not to have to run that command twice.
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Jan 11, 2019
Consolidated efforts from PR ARMmbed#9336. Previous job's env vars would not be populated correctly if the base branch of a PR was not master. Corected by pulling remaining respository information to perform comparison between read-only instance of PR and base branch.
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Jan 11, 2019
Consolidated efforts from PR ARMmbed#9336. Previous job's env vars would not be populated correctly if the base branch of a PR was not master. Corected by pulling remaining respository information to perform comparison between read-only instance of PR and base branch.
|
Continued (and hopefully resolved?) in #9346 |
adbridge
pushed a commit
that referenced
this pull request
Jan 14, 2019
Consolidated efforts from PR #9336. Previous job's env vars would not be populated correctly if the base branch of a PR was not master. Corected by pulling remaining respository information to perform comparison between read-only instance of PR and base branch.
mirelachirica
pushed a commit
to AriParkkila/mbed-os
that referenced
this pull request
Jan 14, 2019
Corrected simplified astyle job behavior when base branch is not master Consolidated efforts from PR ARMmbed#9336. Previous job's env vars would not be populated correctly if the base branch of a PR was not master. Corected by pulling remaining respository information to perform comparison between read-only instance of PR and base branch.
mirelachirica
pushed a commit
to mirelachirica/mbed-os
that referenced
this pull request
Jan 15, 2019
Corrected simplified astyle job behavior when base branch is not master Consolidated efforts from PR ARMmbed#9336. Previous job's env vars would not be populated correctly if the base branch of a PR was not master. Corected by pulling remaining respository information to perform comparison between read-only instance of PR and base branch.
yossi2le
pushed a commit
to yossi2le/mbed-os
that referenced
this pull request
Jan 24, 2019
Consolidated efforts from PR ARMmbed#9336. Previous job's env vars would not be populated correctly if the base branch of a PR was not master. Corected by pulling remaining respository information to perform comparison between read-only instance of PR and base branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From one branch to another, testing travis astyle job (will delete both branches once closed)
Pull request type
Reviewers