Skip to content

Ignore disabled Kinetis USB endpoint interrupts #8596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Oct 30, 2018

Description

Ignore interrupts on disabled USB endpoints. This prevents handling interrupts when in the wrong state.

Prior to this patch when running the serial test on a K64F the assert on line 908 of USBDevice.cpp would sometimes be triggered. This assert indicates that an endpoint 0 IN interrupt occurred before the device was ready.

This occurs during the test_cdc_usb_reconnect test when the host sends a "Set Control Line State" USB request and the device acknowledges it just before USB is disconnected.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 30, 2018

This fixes failures here:
#7755

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2018

Build : SUCCESS

Build number : 3512
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8596/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2018

@cmonr
Copy link
Contributor

cmonr commented Oct 31, 2018

I find this re-result highly suspect. Don't think it's related to the PR, but it's exactly the same...

Going to rerun once more, but if it fails, @c1728p9 you'll need to look into it. Maybe the branch needs a rebase?

/morph test

@mbed-ci
Copy link

mbed-ci commented Nov 1, 2018

@cmonr
Copy link
Contributor

cmonr commented Nov 1, 2018

@c1728p9 When was the last time the feature branch was rebased?

@c1728p9
Copy link
Contributor Author

c1728p9 commented Nov 2, 2018

@cmonr I think it was about a month ago.

@c1728p9 c1728p9 force-pushed the feature-hal-spec-usb-device branch from 05d77ab to aa0cdea Compare November 2, 2018 23:30
Ignore interrupts on disabled USB endpoints. This prevents handling
interrupts when in the wrong state.

Prior to this patch when running the serial test on a K64F the assert
on line 908 of USBDevice.cpp would sometimes be triggered. This
assert indicates that an endpoint 0 IN interrupt occurred before
the device was ready.

This occurs during the test_cdc_usb_reconnect test when the host sends
a "Set Control Line State" USB request and the device acknowledges it
just before USB is disconnected.
@cmonr
Copy link
Contributor

cmonr commented Nov 3, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 3, 2018

Build : SUCCESS

Build number : 3537
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8596/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 3, 2018

@mbed-ci
Copy link

mbed-ci commented Nov 3, 2018

@NirSonnenschein
Copy link
Contributor

NirSonnenschein commented Nov 4, 2018

failure seems unrelated, retrying :
/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 4, 2018

Build : SUCCESS

Build number : 3542
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8596/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 4, 2018

@mbed-ci
Copy link

mbed-ci commented Nov 4, 2018

@0xc0170 0xc0170 merged commit 5cefd0d into ARMmbed:feature-hal-spec-usb-device Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants