-
Notifications
You must be signed in to change notification settings - Fork 3k
Ignore disabled Kinetis USB endpoint interrupts #8596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore disabled Kinetis USB endpoint interrupts #8596
Conversation
This fixes failures here: |
/morph build |
Build : SUCCESSBuild number : 3512 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3131 |
Test : FAILUREBuild number : 3298 |
/morph test |
Test : FAILUREBuild number : 3303 |
I find this re-result highly suspect. Don't think it's related to the PR, but it's exactly the same... Going to rerun once more, but if it fails, @c1728p9 you'll need to look into it. Maybe the branch needs a rebase? /morph test |
Test : FAILUREBuild number : 3309 |
@c1728p9 When was the last time the feature branch was rebased? |
@cmonr I think it was about a month ago. |
05d77ab
to
aa0cdea
Compare
Ignore interrupts on disabled USB endpoints. This prevents handling interrupts when in the wrong state. Prior to this patch when running the serial test on a K64F the assert on line 908 of USBDevice.cpp would sometimes be triggered. This assert indicates that an endpoint 0 IN interrupt occurred before the device was ready. This occurs during the test_cdc_usb_reconnect test when the host sends a "Set Control Line State" USB request and the device acknowledges it just before USB is disconnected.
4649bbe
to
1448840
Compare
/morph build |
Build : SUCCESSBuild number : 3537 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3148 |
Test : FAILUREBuild number : 3321 |
failure seems unrelated, retrying : |
Build : SUCCESSBuild number : 3542 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3153 |
Test : SUCCESSBuild number : 3326 |
Description
Ignore interrupts on disabled USB endpoints. This prevents handling interrupts when in the wrong state.
Prior to this patch when running the serial test on a K64F the assert on line 908 of USBDevice.cpp would sometimes be triggered. This assert indicates that an endpoint 0 IN interrupt occurred before the device was ready.
This occurs during the test_cdc_usb_reconnect test when the host sends a "Set Control Line State" USB request and the device acknowledges it just before USB is disconnected.
Pull request type