Skip to content

LowPowerTimeout tests #5163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fkjagodzinski
Copy link
Member

@fkjagodzinski fkjagodzinski commented Sep 21, 2017

Description

Added unit tests for LowPowerTimeout.

Status

HOLD -- LowPowerTimeout unit tests moved to #5106

CC @bulislaw @0xc0170

Case("Test callback override (with attach_us)", test_override<TimeoutAttachUSTester>),

Case("Test multiple timeouts running in parallel (with attach)", test_multiple<TimeoutAttachTester>),
Case("Test multiple timeouts running in parallel (with attach_us)", test_multiple<TimeoutAttachUSTester>),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two tests with multiple LowPowerTimeout objects fail on K64F, NUCLEO_F070RB, NUCLEO_L476RG. Waiting for the outcome of #5150.

Case("Test multiple timeouts running in parallel (with attach_us)", test_multiple<TimeoutAttachUSTester>),

Case("Test zero delay (with attach)", test_no_wait<TimeoutAttachTester>),
Case("Test zero delay (with attach_us)", test_no_wait<TimeoutAttachUSTester>),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests fail on NUCLEO_F070RB, NUCLEO_F429ZI and NUCLEO_L476RG -- issue #5159.

Added unit tests for LowPowerTimeout API.
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense for this test suite and Timeout be identical just with different implementation used? Maybe we could even try not to duplicate the test functions but push them to a utility file, if that's feasible in our current testing approach.

@fkjagodzinski
Copy link
Member Author

Since test cases for LowPowerTimeout introduced in this PR were identical as those for Timeout in #5106, I've reworked #5106 to include both and avoid code duplication.

@sg- sg- removed the needs: review label Oct 3, 2017
@fkjagodzinski fkjagodzinski deleted the lptimeout_tests branch October 18, 2017 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants