-
Notifications
You must be signed in to change notification settings - Fork 3k
Add doxygen group for HAL specification #5154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add the doxygen group hal_specification as a container group for all the API specifications.
@c1728p9 Does this need to be in it's own file? Alternatively, What/Who would |
@theotherjimmy, this is just information for doxygen. I could move it somewhere else if have any suggestions. It creates a group for the other HAL specifications like in #5008. It looks like this when rendered: |
It is less than idea to have dedicated header files for HAL specification doxygen documentation here and in #5008. The only alternative I know of is adding this documentation into the API headers themselves, which is worse since it would add clutter and could confuse porters. Anyone have other ideas on how this information could be documented in doxygen in a less intrusive way? |
@bulislaw @scartmell-arm happy with the hal specifications in tests/ ? |
What would confuse porter if the API specification is in the API documentation ? Those are valuable information for partners, maintainer and user in development phases. Breaking down information locality and relying on doxygen to assemble everything back is inefficient at the moment for two reasons:
However I do acknowledge that test specification is a completely different beast which cannot be documented in API header files.
Documentation block which do not belong in source file can go in |
I think the documentation should live either in the API headers doxygen (in hal/) or in the porting guide. Test should have usual description/explanation, but I don't think it should add any implementation vital info (they can reiterate something, but shouldn't introduce anything new). |
@pan- I was worried that the test prototypes would confuse porters since it would be a mix of test prototypes and prototypes for functions that needed to be implemented. After some dabbling I found doxygen could be enabled for source files (eliminating the need for a header file for prototypes) and created PR #5213 for this. After moving the behavioral documentation into the HAL api header directly (as suggested by @pan-), there isn't much of a need for a dedicated specification group, so I'm closing this PR. |
Add the doxygen group hal_specification as a container group for all the HAL API specifications.