DNS: Revork DNS query #2982
Merged
DNS: Revork DNS query #2982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjbracey
approved these changes
Oct 11, 2016
Don't ask multiple DNS servers in case of successful connection, even if the response is negative. Make sure the return value is correct.
bulislaw
force-pushed
the
dns_query_fix
branch
from
f337daf to
3d09b19
Compare
|
Fixed, thanks. |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
|
No idea why did it fail -> seems all tests are ok. |
|
@bulislaw I believe I've fixed the issue of it showing up as a failure even though everything is all good. Sorry about that! |
|
makin' it green /morph test |
|
+1 for revork |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 0 All builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix DNS query behavior: don't query more servers if we got reply, make sure the return value is correct.
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Related PRs
List related PRs against other branches:
#2963
@kjbracey-arm @0xc0170