Skip to content

Fix bug uart #15426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2023
Merged

Fix bug uart #15426

merged 2 commits into from
Jun 7, 2023

Conversation

@ozersa
Copy link
Contributor

@ozersa ozersa commented May 25, 2023 •
edited
Loading

Summary of changes

  • Commit1: Do not clear interrupt flag during interrupt initialization
    This causes issue for repeaded initialization while using BufferedSerial mode

  • Commit2: MAX32660, MAX32670 UART performance improvement

Impact of changes

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

0xc0170
0xc0170 previously approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, license check is failing, looks like the package was updated . I'll need to check how to fix this.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 1, 2023

I created #15430 for license issue fix (once merged, this will need to be rebased)

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 1, 2023

I created #15430 for license issue fix (once merged, this will need to be rebased)

Merged, please rebase

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 1, 2023
ozersa added 2 commits June 1, 2023 15:50
@ozersa
Do not clear interrupt flag during initialization
0eac033 
This causes issue for repeaded initialization while using BufferedSerial mode

Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>
@ozersa
MAX32660, MAX32670 UART performance improvement
bdec190 
Signed-off-by: Sadik.Ozer <sadik.ozer@analog.com>
@mergify mergify bot dismissed 0xc0170’s stale review June 1, 2023 12:51

Pull request has been modified.

@ozersa
Copy link
Contributor Author

ozersa commented Jun 2, 2023

I created #15430 for license issue fix (once merged, this will need to be rebased)

Merged, please rebase

It is done.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 5, 2023

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 5, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@saheerb saheerb merged commit f347b89 into ARMmbed:master Jun 7, 2023
@mergify mergify bot removed the ready for merge label Jun 7, 2023
@ozersa ozersa deleted the fix_bug_uart branch June 9, 2023 08:14
@multiplemonomials multiplemonomials mentioned this pull request Sep 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees

No one assigned

Labels

release-type: patch Indentifies a PR as containing just a patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ozersa @0xc0170 @mbed-ci @saheerb