-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incoming DLC len fix #15364
Closed
Closed
Incoming DLC len fix #15364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
previously approved these changes
Jan 3, 2023
0xc0170
added
needs: CI
release-type: patch
Indentifies a PR as containing just a patch
labels
Jan 3, 2023
I suppose it fixes #15361 ? |
jeromecoutant
approved these changes
Jan 3, 2023
Yes |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
@Martyx00 I've missed failing license. Can you rebase to the latest master branch - it should fix it. |
Should be done now. |
@Martyx00 I was away the last days. sorry for the delay. Can you rebase please instead of merging ? To keep the history linear. Thanks. |
mergify
bot
removed
needs: CI
release-type: patch
Indentifies a PR as containing just a patch
labels
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Change on how the incoming CAN message DLC field is processed by the STM HAL. Previously, any value up to
0xF
was allowed. The updated code limits this to value maximum of 8. Values higher than 8 are only used in CANFD which is not affected by this code change.Impact of changes
CAN message DLC value can no longer be higher than 8 in standard CAN mode.
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers