Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32WB55 HCI driver: version dependent rom size #15154

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

rardiol
Copy link
Contributor

@rardiol rardiol commented Oct 26, 2021

Summary of changes

Allows MBED_ROM_SIZE/"target.mbed_rom_size" to go up to 0xE1000 instead of 0xE0000 if using stm32wb5x_BLE_HCILayer_fw.bin with a version >=1.12 since the install address increased from 0x080E0000 to 0x080E1000 in version 1.12.0.

Impact of changes

This assumes any future bump to major or minor version will maintain the new install address. This may be a problem if a future version reduces the install address back.
See https://github.com/STMicroelectronics/STM32CubeWB/blob/master/Projects/STM32WB_Copro_Wireless_Binaries/STM32WB5x/Release_Notes.html

Migration actions required

Documentation

None


Pull request type

Target update

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

Ran the BLE_SecurityAndPrivacy example in a STM32WB55 compiled with "target.mbed_rom_size" : "0xE1000" with BLE stack version 1.12.1 and connected to nRF connect.

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


stm32wb5x_BLE_HCILayer_fw.bin install address increased from 0x080E0000
to 0x080E1000 in version 1.12.0. Assumes any future bump to major or
minor version will maintain the new install address.
See https://github.com/STMicroelectronics/STM32CubeWB/blob/master/Projects/STM32WB_Copro_Wireless_Binaries/STM32WB5x/Release_Notes.html
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 26, 2021
@ciarmcom
Copy link
Member

@rardiol, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0xc0170
0xc0170 previously approved these changes Oct 27, 2021
@mergify mergify bot dismissed 0xc0170’s stale review October 27, 2021 22:22

Pull request has been modified.

@rardiol
Copy link
Contributor Author

rardiol commented Oct 27, 2021

Done. Didn't see the docs sorry.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 28, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Oct 28, 2021
@mbed-ci
Copy link

mbed-ci commented Oct 28, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 07e119b into ARMmbed:master Oct 28, 2021
@mergify mergify bot removed the ready for merge label Oct 28, 2021
@rardiol rardiol deleted the STM32WB55-BLE-HCI_size branch October 28, 2021 12:25
@mbedmain mbedmain added release-version: 6.15.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants