-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32WB55 HCI driver: version dependent rom size #15154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stm32wb5x_BLE_HCILayer_fw.bin install address increased from 0x080E0000 to 0x080E1000 in version 1.12.0. Assumes any future bump to major or minor version will maintain the new install address. See https://github.com/STMicroelectronics/STM32CubeWB/blob/master/Projects/STM32WB_Copro_Wireless_Binaries/STM32WB5x/Release_Notes.html
ciarmcom
added
the
release-type: patch
Indentifies a PR as containing just a patch
label
Oct 26, 2021
@rardiol, thank you for your changes. |
jeromecoutant
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind updating readme part... ? :-)
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_STM/TARGET_STM32WB/README.md#ble-fw
0xc0170
previously approved these changes
Oct 27, 2021
Done. Didn't see the docs sorry. |
0xc0170
approved these changes
Oct 28, 2021
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.15.1
Release-pending
and removed
release-type: patch
Indentifies a PR as containing just a patch
Release-pending
labels
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Allows MBED_ROM_SIZE/"target.mbed_rom_size" to go up to 0xE1000 instead of 0xE0000 if using stm32wb5x_BLE_HCILayer_fw.bin with a version >=1.12 since the install address increased from 0x080E0000 to 0x080E1000 in version 1.12.0.
Impact of changes
This assumes any future bump to major or minor version will maintain the new install address. This may be a problem if a future version reduces the install address back.
See https://github.com/STMicroelectronics/STM32CubeWB/blob/master/Projects/STM32WB_Copro_Wireless_Binaries/STM32WB5x/Release_Notes.html
Migration actions required
Documentation
None
Pull request type
Target update
Test results
Ran the BLE_SecurityAndPrivacy example in a STM32WB55 compiled with "target.mbed_rom_size" : "0xE1000" with BLE stack version 1.12.1 and connected to nRF connect.
Reviewers