Move connectivity lora stubs #14842
Merged
Move connectivity lora stubs #14842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajkan01
force-pushed
the
move_connectivity_lora_stubs
branch
from
93a6ffb to
a62b978
Compare
LDong-Arm
reviewed
Jun 29, 2021
ciarmcom
added
the
release-type: patch
|
@rajkan01, thank you for your changes. |
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
Move the connectivity lorawan stubs into the connectivity/lorawan component directory. So we can avoid duplicating the mbed-os source tree in a central UNITTESTS folder.
Update lorawan unit test to link only with a mbed-stubs-lorawan library that it depends on instead of link with mbed-stubs which is a group of stubs libraries.
Previously, all lorawan headers made as a part of the mbed-headers-connectivity library. To make it easier to separate all the lorawan headers into the separate mbed-headers-lorawan library and keep them, as part of lorawan stubs CMake. This makes the lorawan stubs more self-contained and improves the composition of the library.
Update lorawan unit test to link only with a mbed-headers-lorawan library that it depends on instead of link with mbed-headers which is a group of headers libraries.
Previously the connectivity lorawan stub library depended on `mbed-headers`, which is a collection of all available headers in mbed-os. To make it easier to separate the library, only depend on the headers we're using.
…e dir Previously all the lorawan stubs headers under mbed-stubs-headers, so this PR move all lorawan stubs headers under cellular/tests/UNITTESTS/double directory and update CMake to include stubs headers into mbed-stubs-lorawan library to make lorawan stubs to be self-contained
rajkan01
force-pushed
the
move_connectivity_lora_stubs
branch
from
a62b978 to
46d4247
Compare
LDong-Arm
reviewed
Jul 2, 2021
LDong-Arm
reviewed
Jul 2, 2021
|
@0xc0170 Could you review and start the CI for this PR Thanks |
0xc0170
approved these changes
Jul 6, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.13.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
fixes #14836
mbed-headers, which is a collection of all available headers in mbed-os. To make it easier to separate the library, only depend on the headers it uses.mbed-stubs-headers, so this PR move all lorawan stubs headers underlorawan/tests/UNITTESTS/doubledirectory and updated CMake to include those headers as part ofmbed-stubs-lorawanlibrary to make lorawan stubs to be self-containedImpact of changes
None.
Migration actions required
None
Documentation
To be updated
Pull request type
Test results
Reviewers