Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuvoton: Fix hal_watchdog_kick() with WDT stopped (5.15) #14556

Merged
merged 1 commit into from
May 18, 2021
Merged

Nuvoton: Fix hal_watchdog_kick() with WDT stopped (5.15) #14556

merged 1 commit into from
May 18, 2021

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Apr 16, 2021

Summary of changes

This PR is backport of #14555 to mbed-os-5.15 branch. It tries to fix watchdog_kick() which shall do nothing when WDT is stopped according to WDT HAL spec.

Change targets:

  • NUMAKER_PFM_NANO130
  • NUMAKER_PFM_M453
  • NUMAKER_PFM_NUC472
  • NUMAKER_PFM_M487/NUMAKER_IOT_M487

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@ccli8
Nuvoton: Fix hal_watchdog_kick() with WDT stopped
e0aab8b 
According to HAL spec, hal_watchdog_kick() shall do nothing when WDT is stopped.
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team April 16, 2021 03:30
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 19, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Apr 19, 2021
@mbed-ci
Copy link

mbed-ci commented Apr 19, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 requested a review from andypowers April 26, 2021 12:00
andypowers
andypowers reviewed May 13, 2021
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 7f25b2c into ARMmbed:mbed-os-5.15 May 18, 2021
@mergify mergify bot removed the ready for merge label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypowers andypowers andypowers left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccli8 @ciarmcom @0xc0170 @mbed-ci @andypowers