[feature-wisun] Added new start methods to Wi-SUN BR with WisunInterface parameter and deprecated the old ones #14462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikaleppanen, thank you for your changes. |
artokin
reviewed
Apr 6, 2021
| * \return MESH_ERROR_NONE on success. | ||
| * \return MESH_ERROR_UNKNOWN in case of failure. | ||
| * */ | ||
| MBED_DEPRECATED_SINCE("mbed-os-5.15", "Using NetworkInterface type for mesh_if is deprecated, use WisunInterface instead") |
There was a problem hiding this comment.
Please update the deprecated version to match the next Mbed OS 5.15 version, 5.15.8?.
…d deprecated the old ones Previously WisunBorderRouter start() used NetworkInterface type for mesh interface, although only WisunInterface type is possible for the call. Added a new overloads of the start with the WisunInterface as mesh interface type and deprecated the old ones. This makes the calls stricter about the interface type and safer. It also allows to remove the reinterpret_cast that causes compiler warning on ARM compiler.
|
Corrected mbed-os deprecation version and rebased over latest mbed-os |
artokin
approved these changes
Apr 8, 2021
|
CI started |
Test run: SUCCESSSummary: 10 of 10 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Previously WisunBorderRouter start() used NetworkInterface type for mesh interface, although only WisunInterface type is possible for the call. Added a new overloads of the start with the WisunInterface as mesh interface type and deprecated the old ones. This makes the calls stricter about the interface type and safer. It also allows to remove the reinterpret_cast that causes
compiler warning on ARM compiler.
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@mikter @artokin