Skip to content

targets:evkbimxrt1050: Adjust the SEMC re-order rules #13927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2020
Merged

targets:evkbimxrt1050: Adjust the SEMC re-order rules #13927

merged 1 commit into from
Dec 14, 2020

Conversation

@liugang-gavin
Copy link
Contributor

@liugang-gavin liugang-gavin commented Nov 19, 2020

Update the BMCR0, BMCR1 registers to adjust the SEMC
re-order rules. This can improve the SDRAM stability
under multiple AXI masters system.

Signed-off-by: Gavin Liu gang.liu@nxp.com

Summary of changes

Update the BMCR0, BMCR1 registers to adjust the SEMC
re-order rules. This can improve the SDRAM stability
under multiple AXI masters system.

Impact of changes

Migration actions required

Documentation

No

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@liugang-gavin
targets:evkbimxrt1050: Adjust the SEMC re-order rules
e600c57 
Update the BMCR0, BMCR1 registers to adjust the SEMC
re-order rules. This can improve the SDRAM stability
under multiple AXI masters system.

Signed-off-by: Gavin Liu <gang.liu@nxp.com>
@ciarmcom
Copy link
Member

ciarmcom commented Nov 19, 2020

@liugang-gavin, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team November 19, 2020 12:00
@0xc0170 0xc0170 requested a review from artokin November 19, 2020 12:42
@mergify mergify bot added needs: CI and removed needs: review labels Nov 19, 2020
@artokin artokin requested a review from mikter November 20, 2020 08:52
@teetak01
Copy link
Contributor

teetak01 commented Nov 27, 2020

@liugang-gavin should the same PR be made also vs. Mbed OS master?

@liugang-gavin
Copy link
Contributor Author

liugang-gavin commented Nov 27, 2020

@liugang-gavin should the same PR be made also vs. Mbed OS master?

yes, it's better to apply the patch to master branch.

@adbridge
Copy link
Contributor

adbridge commented Dec 11, 2020

Ci started

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@artokin artokin requested a review from tz-arm December 14, 2020 08:42
@artokin artokin merged commit 5547499 into ARMmbed:feature-wisun Dec 14, 2020
@mergify mergify bot removed the ready for merge label Dec 14, 2020
This was referenced Feb 22, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mikter mikter Awaiting requested review from mikter

+3 more reviewers

@artokin artokin artokin approved these changes

@teetak01 teetak01 teetak01 approved these changes

@tz-arm tz-arm tz-arm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: feature branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@liugang-gavin @ciarmcom @teetak01 @adbridge @mbed-ci @0xc0170 @artokin @tz-arm