-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix bare metal builds on Cypress targets #13864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume files I modified are Mbed-specific code, since DEVICE_FLASH and TARGET_TFM are already used there. |
LDong-Arm
commented
Nov 4, 2020
0xc0170
previously approved these changes
Nov 5, 2020
kyle-cypress
reviewed
Nov 5, 2020
This fixes bare metal builds
SCL is for the Cypress Ethernet driver which is not currently compatible with bare metal.
8fc0a7b
to
810884b
Compare
kyle-cypress
approved these changes
Nov 6, 2020
0xc0170
approved these changes
Nov 10, 2020
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes: #13108
This PR fixes bare metal build of two Cypress targets:
COMPONENT_SCL
depends on the EMAC/LWIP stack which is absent on bare metal. Add anmbed_lib.json
to disable its build in the bare metal profile.cytfm_flash*
dependent on TF-M and PSA presence.Impact of changes
https://github.com/ARMmbed/mbed-os-example-blinky-baremetal now compiles successfully on those Cypress targets.
Migration actions required
None.
Documentation
None.
Pull request type
Test results
Reviewers
@MarceloSalazar @ARMmbed/mbed-os-core @ARMmbed/team-cypress