Skip to content

Fix bare metal builds on Cypress targets #13864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented Nov 4, 2020

Summary of changes

Fixes: #13108

This PR fixes bare metal build of two Cypress targets:

  • CYSBSYSKIT_01: COMPONENT_SCL depends on the EMAC/LWIP stack which is absent on bare metal. Add an mbed_lib.json to disable its build in the bare metal profile.
  • CYTFM_064B0S2_4343W: Make cytfm_flash* dependent on TF-M and PSA presence.

Impact of changes

https://github.com/ARMmbed/mbed-os-example-blinky-baremetal now compiles successfully on those Cypress targets.

Migration actions required

None.

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@MarceloSalazar @ARMmbed/mbed-os-core @ARMmbed/team-cypress


@LDong-Arm
Copy link
Contributor Author

I assume files I modified are Mbed-specific code, since DEVICE_FLASH and TARGET_TFM are already used there.

@0xc0170 0xc0170 requested a review from a team November 5, 2020 09:30
0xc0170
0xc0170 previously approved these changes Nov 5, 2020
@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Nov 5, 2020
SCL is for the Cypress Ethernet driver which is not currently
compatible with bare metal.
@LDong-Arm LDong-Arm force-pushed the cypress_baremetal_fixes branch from 8fc0a7b to 810884b Compare November 6, 2020 10:09
@mergify mergify bot dismissed 0xc0170’s stale review November 6, 2020 10:10

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 10, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit f867a94 into ARMmbed:master Nov 11, 2020
@mergify mergify bot removed the ready for merge label Nov 11, 2020
@mbedmain mbedmain added release-version: 6.5.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress targets fail to compile blinky-baremetal in Mbed OS 6
5 participants