Skip to content

STM32L4 update drivers version to CUBE V1.16.0 #13741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 20, 2020
Merged

STM32L4 update drivers version to CUBE V1.16.0 #13741

merged 6 commits into from
Oct 20, 2020

Conversation

jeromecoutant
Copy link
Collaborator

@jeromecoutant jeromecoutant commented Oct 8, 2020 •
edited
Loading

Summary of changes

ST Cube drivers version is updated from V1.14.0 to V1.16.0
which is the latest official version from:

https://github.com/STMicroelectronics/STM32CubeL4/

  • directories have been restructured to be aligned with other STM32 families
  • Sub-family MCU has been introduced in targets.json to help custom boards use

@ARMmbed/team-st-mcd

Impact of changes

fix #13751

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

Tested by ST CI

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 8, 2020
@ciarmcom ciarmcom requested a review from a team October 8, 2020 10:30
@ciarmcom
Copy link
Member

ciarmcom commented Oct 8, 2020

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 13, 2020

I restarted CI but again Travis caught the older commit :/

@0xc0170 0xc0170 closed this Oct 13, 2020
@mergify mergify bot removed needs: review release-type: patch Indentifies a PR as containing just a patch labels Oct 13, 2020
@0xc0170 0xc0170 reopened this Oct 13, 2020
@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Oct 13, 2020
adbridge
adbridge previously approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is driver code going to approve as is without in depth review

@adbridge
Copy link
Contributor

Started Ci , @0xc0170 do you know why the licence check has failed ?

@mbed-ci
Copy link

mbed-ci commented Oct 14, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@mergify
Copy link

mergify bot commented Oct 15, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

Started Ci , @0xc0170 do you know why the licence check has failed ?

The rebase is needed , once done, Travis should catch the proper SHA this time.

@jeromecoutant
Copy link
Collaborator Author

The rebase is needed , once done, Travis should catch the proper SHA this time.

Done

@mergify mergify bot dismissed adbridge’s stale review October 15, 2020 10:04

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

@jeromecoutant The latest travis fix should remove the license check failure, shall we rebase one last time ? Lets wait for other cube updates, if the latest master fixes the issue

@jeromecoutant
Copy link
Collaborator Author

@0xc0170 done

@mergify mergify bot added needs: work and removed needs: CI labels Oct 15, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 19, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@mergify mergify bot added needs: work and removed needs: CI labels Oct 19, 2020
0xc0170
0xc0170 previously requested changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one file in question

I can see SPDX being printed in the Travis logs, should not with the recent master. , just in case, please rebase.

test_loop.sh Outdated
@@ -0,0 +1,29 @@
#!/bin/sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs a license header. However, looking at the script, it should not be in this PR (it's in the root) ?

Copy link
Collaborator Author

@jeromecoutant jeromecoutant Oct 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups... file removed

@mergify mergify bot dismissed 0xc0170’s stale review October 20, 2020 06:53

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 20, 2020

CI started (license check passed, all fine now)

@mbed-ci
Copy link

mbed-ci commented Oct 20, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit de5da38 into ARMmbed:master Oct 20, 2020
@mergify mergify bot removed the ready for merge label Oct 20, 2020
@jeromecoutant jeromecoutant deleted the PR_L4_1160 branch October 20, 2020 10:10
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge adbridge left review comments

Assignees
No one assigned
Labels
release-version: 6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DISCO-BL475E-IOT01A doesn't exit deep sleep
6 participants
@jeromecoutant @ciarmcom @0xc0170 @adbridge @mbed-ci @mbedmain