Mutex::unlock - decrement _count inside lock #12983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Mutex::unlock` was decrementing the `_count` member after releasing the mutex, which meant it was unprotected, exposing a race that could corrupt the count. This could lead to an assert in `ConditionVariable::wait`, which checks that the mutex count is one.
|
@kjbracey-arm, thank you for your changes. |
0xc0170
approved these changes
May 15, 2020
AriParkkila
approved these changes
May 18, 2020
Closed
evedon
approved these changes
May 18, 2020
|
CI started |
|
Does this need a rebase to clear that test error? |
|
CI restarted (should no need a rebase, master was fixed) |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
mergify
bot
added
release version missing
|
This PR does not contain release version label after merging. |
0xc0170
removed
the
release version missing
adbridge
added
release-version: 6.1.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Mutex::unlockwas decrementing the_countmember after releasing the mutex, which meant it was unprotected, exposing a race that could corrupt the count.This could lead to an assert in
ConditionVariable::wait, which checks that the mutex count is one.Fixes #12976. Bug was introduced in #10358 (5.13 and 5.12.2).
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@AriParkkila, @evedon