MIMXRT1050: Update for deep sleep latency #12364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@mmahadevan108, thank you for your changes. |
0xc0170
previously requested changes
Feb 5, 2020
Contributor
0xc0170
left a comment
0xc0170
left a comment
There was a problem hiding this comment.
Why these lines are not removed (it is now dead code) ? I would rather remove it. It's stored in the history so can be found and reverted or changed.
bulislaw
reviewed
Feb 5, 2020
Member
bulislaw
left a comment
bulislaw
left a comment
There was a problem hiding this comment.
Why are you introducing a dead code? If for some use cases we expect users to want to "revert" this maybe worth introducing a named macro?
1. Do not disable and enable osillators during deep sleep entry and exit 2. Increase the deep sleep to pass tests Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
mmahadevan108
force-pushed
the
MXRT1050_Deep_Sleep_Latency
branch
from
5f2399a to
8b46e91
Compare
Contributor
Author
|
Deleted the unused lines. |
0xc0170
approved these changes
Feb 6, 2020
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170
added
the
release-version: 6.0.0-alpha-2
Contributor
|
Requested by Tuomo for consideration for LTS branch. |
Contributor
|
This went to a feature branch so assuming this will not go to 5.15 proper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
entry and exit
Impact of changes
NONE
Migration actions required
NONE
Documentation
NONE
Pull request type
Test results
Reviewers
@maclobdell