Pr dev/remove hardcoded timeout in cypress bt code #12164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced a hardcoded timeout in CyH4TransportDriver.cpp with a cypress hal function. The cypress PUTC hal API only blocks until data has been send into the HW buffer, not until all data has been out of the HW buffer. Modified an API to block untill all tx transmit is complete. This allows the removal of a hardcoded timeout in CyH4TransportDriver.cpp that waits for data int the HW buffer to be sent.
|
@shuopeng-deng, thank you for your changes. |
bulislaw
approved these changes
Dec 23, 2019
0xc0170
approved these changes
Dec 23, 2019
|
@ARMmbed/team-cypress has anybody reviewed this internally from your side ? |
|
@adbridge yes, this change was reviewed internally. |
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Failure doesn't look related, I'll restart the CI. |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170
added
release-version: 6.0.0-alpha-1
adbridge
added
Release review required
and removed
release-version: 6.0.0-alpha-1
|
This PR does not contain release version label after merging. |
1 similar comment
|
This PR does not contain release version label after merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Replaced a hardcoded timeout in CyH4TransportDriver.cpp with a cypress hal function. The cypress PUTC hal API only blocks until data has been send into the HW buffer, not until all data has been out of the HW buffer. Modified an API to block until all tx transmit is complete. This allows the removal of a hardcoded timeout in CyH4TransportDriver.cpp that waits for data int the HW buffer to be sent.
The 5000 us delay was insufficient on some Cypress board which may cause the radio to go to sleep prematurely and BLE packets to be delay until the radio wakes up again.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
CYW9P62S1_43438EVB_01_GT.txt
Reviewers