Remove unsupported folder #12128
Merged
Remove unsupported folder #12128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mbed OS was carrying this directory for a long time. The main reason was to enable users to benefit from some form of USB stack. Now when there is proper implementation of USB stack in Mbed I think it's time for unsupported directory to go. If any other functionality present in this directory will be needed it'll need to be introduced in Mbed OS properly.
|
You don't remove tests part ? |
|
@bulislaw, thank you for your changes. |
Which tests part? |
kjbracey
approved these changes
Dec 18, 2019
Mmm, seems that mail we receive from GitHub is not complete... |
0xc0170
approved these changes
Dec 19, 2019
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Failure looks like a ci issue so restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170
added
release-version: 6.0.0-alpha-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Mbed OS was carrying the
unsupporteddirectory for a long time. The main reason wasto enable users to benefit from some form of USB stack. Now when there
is a proper implementation of USB stack in Mbed I think it's time for
unsupported to go. If any other functionality present in this
directory will be needed it'll need to be introduced in Mbed OS
properly.
Impact of changes
As the name suggest 'unsupported' directory was unsupported, but it was there that means our community was free to use any of the functionality present. So in theory it is breaking change, even if the code was never properly supported.
Migration actions required
Removed functionality was never supported and its use was not recommended. If you used USB device mode, please port your code to use the supported version from drivers directory. If you need any other features please consider contributing it properly to Mbed.
Documentation
Not needed, all removed features were unsupported in Mbed OS 5.
Pull request type
Test results
Reviewers
@evedon @MarceloSalazar @kjbracey-arm