Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 413 dragonfly #11573

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Add 413 dragonfly #11573

merged 1 commit into from
Oct 7, 2019

Conversation

felser
Copy link
Contributor

@felser felser commented Sep 26, 2019 •
edited by 0xc0170
Loading

Description

The MTS_DRAGONFLY_F413RH platform is a cellular enabled device using an STM32F413RH processor. The initial radio type is an LTE Cat 1 Sprint enabled radio from Telit.

Test result files are attached.
gcc_platform_tests.txt
arm6_platform_tests.txt

Pull request type

[ ] Fix
[ ] Refactor
[x ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team September 26, 2019 15:00
@ciarmcom
Copy link
Member

@felser, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-tools please review.

@bentcooke
Copy link
Contributor

@ARMmbed/mbed-os-maintainers could you please review / approve / merge at your earliest convenience and indicate if this would make it into the 5.14.1 release?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

@ARMmbed/mbed-os-maintainers could you please review / approve / merge at your earliest convenience and indicate if this would make it into the 5.14.1 release?

Changes look good to me, I'll schedule CI job.

Meanwhile, @felser Please provide description about this new target - few words should be sufficient. Also add testing logs (always with a new target).

0xc0170
0xc0170 requested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As requested above - description + test logs

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

Ci started meanwhile

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2019

I also noticed 2 merge commits, as this is just adding new target, can you rebase your branch to clean-up the history?

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@felser
Copy link
Contributor Author

felser commented Sep 30, 2019

The MTS_DRAGONFLY_F413RH platform is a cellular enabled device using an STM32F413RH processor. The initial radio type is an LTE Cat 1 Sprint enabled radio from Telit.

I will provide a rebase/squash of my branch soon.

Here are the test result files again. I did drag and drop them with the initial PR too. I'm not sure if there is something more I need to do in order for them to be visible.
arm6_platform_tests.txt
gcc_platform_tests.txt

@felser
Copy link
Contributor Author

felser commented Sep 30, 2019

The rebase/squash of my branch has been pushed.

@0xc0170 0xc0170 self-requested a review October 1, 2019 10:48
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 1, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 1, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

bulislaw
bulislaw reviewed Oct 2, 2019
View reviewed changes
targets/targets.json
],
"components_add": ["FLASHIAP", "SPIF"],
"bootloader_supported": true,
"release_versions": ["2", "5"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that really a Mbed 2 target? Was that tested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our Dragonfly series using the STM32F411 started with mbed version 2. So we may have customer's still using it. We have some code that was built for the 411 Dragonfly using version 2 that I ran on this platform. Does that satisfy your question?

@adbridge
Copy link
Contributor

adbridge commented Oct 3, 2019

Restarted CI

@felser
Copy link
Contributor Author

felser commented Oct 3, 2019

I just received an email describing the new mbed-os release process. I'm wondering if the dragonfly 413 platform support will make the third Wednesday of October release? It looks like we still need a review for the mbed-os-tools change. Please let me know if there is anything remaining that anyone needs from my side. I think I have responded to or satisfied all the requests above.
Thank you!

@adbridge
Copy link
Contributor

adbridge commented Oct 7, 2019

@felser as long as we can get this through the CI I see no reason why this wouldn't make the 5.14.1 release.

@adbridge
Copy link
Contributor

adbridge commented Oct 7, 2019

Ci restarted

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 4
Build artifacts

@adbridge adbridge merged commit f1295b9 into ARMmbed:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw left review comments

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.1 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@felser @ciarmcom @bentcooke @0xc0170 @mbed-ci @adbridge @bulislaw @SeppoTakalo