Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplicy QSPIF target overrides for PSoC6 #11567

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

kyle-cypress
Copy link

Description

All current PSoC 6 targets support the same QSPI frequency and minimum
program size. So specify a single entry rather than duplicating for
each device.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-cypress

Release Notes

All current PSoC 6 targets support the same QSPI frequency and minimum
program size. So specify a single entry rather than duplicating for
each device.
@ciarmcom ciarmcom requested review from a team September 25, 2019 23:00
@ciarmcom
Copy link
Member

@kyle-cypress, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@VeijoPesonen VeijoPesonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MCU_PSOC6_M4 maybe? The only MCU_PSOC6_M0 based device seem to remove support for QSPI. This is just me thinking out loud, so if you're fine with the current changes this can go in from my point of view.

@kyle-cypress
Copy link
Author

MCU_PSOC6_M4 maybe? The only MCU_PSOC6_M0 based device seem to remove support for QSPI. This is just me thinking out loud, so if you're fine with the current changes this can go in from my point of view.

That is a good question. We don't support QSPI on the M0 in our current software solution, but the hardware is physically present, so it's not wrong to say that these settings apply to both. Therefore, I'm inclined to leave the override as more generic, and have one less place to update if a future M0 target does enable QSPI support.

@adbridge
Copy link
Contributor

adbridge commented Oct 7, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@maclobdell
Copy link
Contributor

What happens if a new board comes along that requires different settings? Not sure if that is likely, but if that does happen, this might have to be changed back. Either way it is a small issue.

@kyle-cypress
Copy link
Author

What happens if a new board comes along that requires different settings? Not sure if that is likely, but if that does happen, this might have to be changed back. Either way it is a small issue.

If a new board comes along that requires something different I would expect we would add a board-level target override which would take precedence over the general MCU_PSOC4 value. I tested this scenario and confirmed that the expected values get placed in mbed_config.h.

The intent here is not to say that all PSoC 6 targets will always have the same settings; it is that most of them do and so it is more maintainable (and easier to see which ones are actually different) to define only the default and the handful of exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants