Fix added to unlock AT handler mutex #11526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarceloSalazar Will this fix be part of mbed-os release 5.14 ? Thanks |
AriParkkila
approved these changes
Sep 19, 2019
| @@ -116,6 +116,7 @@ nsapi_error_t UBLOX_AT::init() | |||
| err = _at->at_cmd_discard("+CFUN", "=1"); // set full functionality | |||
| } | |||
| #endif | |||
| _at->unlock(); | |||
There was a problem hiding this comment.
Could be return _at.unlock_return_error(); ?
fahimalavi
force-pushed
the
at_unlock_error_fix
branch
from
6fa88a7 to
a269f71
Compare
adbridge
approved these changes
Sep 19, 2019
|
CI started |
0xc0170
approved these changes
Sep 19, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix added to unlock AT handler mutex introduced in mbed-os 5.14 release candidates
Targets verified with this fix : UBLOX_C030_U201 & UBLOX_C030_R412M
Pull request type
Reviewers
@RobMeades @MarceloSalazar @AriParkkila
Release Notes
In mbed-os 5.14 release candidate1 and 2, none of u-blox modem is working due to this problem