Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ST DISCO-H747I introduction #11384

Merged
merged 5 commits into from
Sep 10, 2019
Merged

ST DISCO-H747I introduction #11384

merged 5 commits into from
Sep 10, 2019

Conversation

jeromecoutant
Copy link
Collaborator

Description

Hi

As discussed with @MarceloSalazar we propose to introduce this dual core MCU target in 2 steps:
1- this pull request to support M7 core
2- a coming PR to add M4 core support

https://www.st.com/en/evaluation-tools/stm32h747i-disco.html
https://www.st.com/en/microcontrollers-microprocessors/stm32h747zi.html

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-st-mcd

Release Notes

@ciarmcom ciarmcom requested a review from a team August 30, 2019 15:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2019

Please review Travis failures

@LMESTM
Copy link
Contributor

LMESTM commented Sep 6, 2019

@0xc0170 : @jeromecoutant has solved the travis build issue few days back ...

0xc0170
0xc0170 requested changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New files should have 2019 copyright

Also can we add license headers to linker scripts? They are often flagged in the license checks

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 6, 2019

@0xc0170 : @jeromecoutant has solved the travis build issue few days back ...

Always leave a comment with an update = notification.

@jeromecoutant
Copy link
Collaborator Author

New files should have 2019 copyright

Also can we add license headers to linker scripts? They are often flagged in the license checks

Done

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 10, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 10, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@jeromecoutant
Copy link
Collaborator Author

Test run: FAILED

Rebase and issue corrected done

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 10, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 10, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 10, 2019

@jeromecoutant Tests logs attached? I cant locate them here

@jeromecoutant
Copy link
Collaborator Author

report_DISCO_H747I.txt

@0xc0170 0xc0170 merged commit c897e04 into ARMmbed:master Sep 10, 2019
@jeromecoutant jeromecoutant deleted the PR_H747_CM7 branch September 11, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMESTM LMESTM LMESTM approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.1 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromecoutant @ciarmcom @0xc0170 @LMESTM @mbed-ci