Replace TEST_ASSERT_INT_WITHIN usage in netsocket tests #11289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPCore's netsocket tests are expected to run all tests even if some of them fail. The TEST_ASSERT_INT_WITHIN macro sets a global variable Unity.CurrentTestFailed which prevents further checks and gives incorrect failure count. Other assertion macros in Unity do not do that.
|
@michalpasztamobica, thank you for your changes. |
|
Tested OK on my side. |
VVESTM
approved these changes
Aug 23, 2019
SeppoTakalo
approved these changes
Aug 23, 2019
0xc0170
approved these changes
Aug 23, 2019
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IPCore's netsocket tests are expected to run all tests even if some of them fail. The TEST_ASSERT_INT_WITHIN macro sets a global variable Unity.CurrentTestFailed which prevents further checks and gives incorrect results and failure count. Other assertion macros in Unity do not do that.
We've considered updating the Unity test code, but other modules also use this macro and it's hard to judge whether they rely on the macro's behavior or not.
The latest version of Unity does not allow the test suite to run after the first assertion triggers.
Fixes #10941.
Pull request type
Reviewers
@SeppoTakalo
@VVESTM
@jeromecoutant
@VeijoPesonen