Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target TT_: fix compilation errors #11278

Closed
wants to merge 1 commit into from

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Aug 21, 2019

Description

They define slave for spi, rtc but do not contain implementation - removing them.
Fixes #11143 - nightly tests, see the latest failures: http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/ARMmbed/mbed-os/mbed-os-ci-nightly/artifacts/master/315/build-ARM/FAIL/TT_M3HQ/

Tested locally, compiling OK.

Fixes #11143.

cc @Ronny-Liu @ThunderSoft123

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

They define slave for spi, rtc but do not contain implementation - removing them.
Fixes ARMmbed#11143
@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 21, 2019

Note: fixes nightly build failure for this target

@ciarmcom ciarmcom requested a review from a team August 21, 2019 13:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@jamesbeyond
Copy link
Contributor

Hi @0xc0170, seem the failure related to RTC, why we have to trun off SPI and I2C async ?

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 22, 2019

Hi @0xc0170, seem the failure related to RTC, why we have to trun off SPI and I2C async ?

If you review, #11143 (comment) - you can see - rtc, i2c and spi are to blame - their implementation was not there - async/slave for instance. They were enabled without being implemented.

I checked every _api.c implementation before removing to make sure they are not implemented. The HAL implementation is not there for these removed "DEVICE_".

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 22, 2019

Please review, would like to have this on master today to get nightly -1 failure

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 23, 2019

Pls review today

Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 26, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 27, 2019

CI restarted

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 28, 2019

This is now part of roll up PR: #11358

Please do not change this PR, or if you do, let us know asap

@0xc0170
Copy link
Contributor Author

0xc0170 commented Aug 28, 2019

Resolved via #11358

@0xc0170 0xc0170 closed this Aug 28, 2019
@0xc0170 0xc0170 deleted the fix_tt_targets branch August 28, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TT_M3HQ fails to compile with mbed-os master
5 participants