-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target TT_: fix compilation errors #11278
Conversation
They define slave for spi, rtc but do not contain implementation - removing them. Fixes ARMmbed#11143
Note: fixes nightly build failure for this target |
@0xc0170, thank you for your changes. |
Hi @0xc0170, seem the failure related to |
If you review, #11143 (comment) - you can see - rtc, i2c and spi are to blame - their implementation was not there - async/slave for instance. They were enabled without being implemented. I checked every |
Please review, would like to have this on master today to get nightly -1 failure |
Pls review today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI started |
Test run: FAILEDSummary: 2 of 11 test jobs failed Failed test jobs:
|
CI restarted |
This is now part of roll up PR: #11358 Please do not change this PR, or if you do, let us know asap |
Resolved via #11358 |
Description
They define slave for spi, rtc but do not contain implementation - removing them.
Fixes #11143 - nightly tests, see the latest failures: http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/ARMmbed/mbed-os/mbed-os-ci-nightly/artifacts/master/315/build-ARM/FAIL/TT_M3HQ/
Tested locally, compiling OK.
Fixes #11143.
cc @Ronny-Liu @ThunderSoft123
Pull request type
Reviewers
Release Notes