Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__cplusplus guard fixed pwmout_device.h for STM32F4 #11150

Merged
merged 1 commit into from
Aug 9, 2019
Merged

__cplusplus guard fixed pwmout_device.h for STM32F4 #11150

merged 1 commit into from
Aug 9, 2019

Conversation

byq77
Copy link
Contributor

@byq77 byq77 commented Aug 1, 2019

Description

This bug prevented using this header in cpp code directly.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

This error prevented using this header in cpp code directly.
@ciarmcom ciarmcom requested a review from a team August 1, 2019 13:00
@ciarmcom
Copy link
Member

ciarmcom commented Aug 1, 2019

@byq77, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 8, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 8, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@LMESTM
Copy link
Contributor

LMESTM commented Aug 9, 2019

LGTM - but loks like it needs to be fixed on other STM32 families as well
I will send a PR to complete this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants