-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arduino Nano 33 BLE target #11137
Conversation
@facchinm, thank you for your changes. |
@facchinm Could you also attach test results for 3 toolchains (should be part of the PR that adds new target). I'll schedule CI run in the meantime |
CI started |
Test run: FAILEDSummary: 3 of 4 test jobs failed Failed test jobs:
|
The error arise from
because we don't have LED2 on this board. @0xc0170 Should I declare it anyway as NC ? Sorry for the (probably stupid) question but it's my first time contribution here 🙂 |
Yes, please declare as NC |
5318852
to
49a3021
Compare
Force pushed, thanks |
49a3021
to
bd09884
Compare
CI started @facchinm How was this tested? Can you please add test logs for toolchains here. |
Sorry @0xc0170 but I couldn't find any documentation about the testing requirements (which ones to perform and if all toolchains are needed). I've only been targeting GCC_ARM but, since there's no architecture update but just an end target, the results should match the ones for other nRF52840 boards. |
I would at least run New target should contain test logs as part of the pull request. |
Great, thanks. It could take a bit since we use another upload method (no DAPlink) so of course |
Test output (only --compile ATM) w/ GCC_ARM |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
Waiting for pr-merge, @ARMmbed/mbed-os-test please review |
Be aware you were using |
Description
Request to add Arduino Nano 33 BLE as an mbed target (under nRF52840 family)
Pull request type
Reviewers
Release Notes