Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arduino Nano 33 BLE target #11137

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Conversation

facchinm
Copy link
Contributor

Description

Request to add Arduino Nano 33 BLE as an mbed target (under nRF52840 family)

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested a review from a team July 31, 2019 15:00
@ciarmcom
Copy link
Member

@facchinm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0Grit
Copy link

0Grit commented Jul 31, 2019

@AGlass0fMilk

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 8, 2019

@facchinm Could you also attach test results for 3 toolchains (should be part of the PR that adds new target).

I'll schedule CI run in the meantime

@0xc0170 0xc0170 changed the title [TARGET] Add Arduino Nano 33 BLE target Add Arduino Nano 33 BLE target Aug 8, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 8, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 8, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@facchinm
Copy link
Contributor Author

facchinm commented Aug 8, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

The error arise from

        Building project ticker (ARDUINO_NANO33BLE, ARMC6)
        Scan: ARM
        Scan: ticker
        Compile [100.0%]: main.cpp
        [Error] main.cpp@42,17: use of undeclared identifier 'LED2'; did you mean 'LED1'?

because we don't have LED2 on this board. @0xc0170 Should I declare it anyway as NC ? Sorry for the (probably stupid) question but it's my first time contribution here 🙂

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 8, 2019

Yes, please declare as NC

@facchinm
Copy link
Contributor Author

facchinm commented Aug 8, 2019

Force pushed, thanks

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

CI started

@facchinm How was this tested? Can you please add test logs for toolchains here.

@facchinm
Copy link
Contributor Author

facchinm commented Aug 9, 2019

Sorry @0xc0170 but I couldn't find any documentation about the testing requirements (which ones to perform and if all toolchains are needed). I've only been targeting GCC_ARM but, since there's no architecture update but just an end target, the results should match the ones for other nRF52840 boards.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

I would at least run mbed test -t GCC_ARM -m ARDUINO_NANO33BLE in your case.

New target should contain test logs as part of the pull request.

@facchinm
Copy link
Contributor Author

facchinm commented Aug 9, 2019

Great, thanks. It could take a bit since we use another upload method (no DAPlink) so of course mbedgt complains a bit

@facchinm
Copy link
Contributor Author

facchinm commented Aug 9, 2019

Test output (only --compile ATM) w/ GCC_ARM
ARDUINO_NANO33BLE_compile_tests.tar.gz

@mbed-ci
Copy link

mbed-ci commented Aug 9, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 12, 2019

Waiting for pr-merge, @ARMmbed/mbed-os-test please review

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 13, 2019

Be aware you were using [Warning] @,: Compiler version mismatch: Have 9.1.0; expected version >= 6.0.0 and < 7.0.0. We are still at compiler version 6.x

@0xc0170 0xc0170 merged commit be23d3c into ARMmbed:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants