Skip to content

Flatten USB driver directory structure #11095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Flatten USB driver directory structure #11095

wants to merge 4 commits into from

Conversation

gpsimenos
Copy link
Contributor

Description

Moved all USB source files directly under drivers/usb/

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@hugueskamba
Copy link
Collaborator

@gpsimenos There is a CI test failure.

@gpsimenos
Copy link
Contributor Author

@gpsimenos There is a CI test failure.

The failure has nothing to do with the changes in this PR. I didn't touch events at all.

@hugueskamba
Copy link
Collaborator

hugueskamba commented Jul 23, 2019

@gpsimenos There is a CI test failure.

The failure has nothing to do with the changes in this PR. I didn't touch events at all.

The events Makefile tests pass on my machine. It might just be an issue with Travis. Try pushing a dummy commit to re-trigger the CI tests.

@ciarmcom ciarmcom requested a review from a team July 23, 2019 13:00
@ciarmcom
Copy link
Member

@gpsimenos, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mbed-ci
Copy link

mbed-ci commented Jul 23, 2019

Test run: FAILED

Summary: 4 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

gpsimenos and others added 3 commits July 25, 2019 09:57
Add missing header file inclusion.
The "bare-metal" profile which is defined in
mbed-os/platform/bare_metal/mbed_lib.json only includes only the
`platform` and `drivers` dirs in the build.

The problem is due to the fact that USB related modules are now
included in the build as part of the `drivers` library.
They previously were not included given they were outside the `drivers`
directory (in the `usb` dir).

The solution is to stick an mbed_lib.json file under
`mbed-os/drivers/source/usb` in order to make it a library so it does
not get automatically included given the `requires` statement in
mbed-os/platform/bare_metal/mbed_lib.json
@SeppoTakalo
Copy link
Contributor

@hugueskamba Please check the unittest failures. Thanks.

[2019-07-25T09:07:07.698Z] CMake Error at CMakeLists.txt:182 (add_library):

[2019-07-25T09:07:07.698Z]   Cannot find source file:

[2019-07-25T09:07:07.698Z] 

[2019-07-25T09:07:07.698Z]     ../drivers/Watchdog.cpp

The Cmake file described hardcoded the relative path to the source file
being tested. Changed it to be the new location of the source file.
@hugueskamba
Copy link
Collaborator

hugueskamba commented Jul 25, 2019

@hugueskamba Please check the unittest failures. Thanks.

[2019-07-25T09:07:07.698Z] CMake Error at CMakeLists.txt:182 (add_library):

[2019-07-25T09:07:07.698Z]   Cannot find source file:

[2019-07-25T09:07:07.698Z] 

[2019-07-25T09:07:07.698Z]     ../drivers/Watchdog.cpp

@SeppoTakalo Thank you. I just pushed a commit to fix to this. 7efaedd
Can you please run the test again?

@mbed-ci
Copy link

mbed-ci commented Jul 25, 2019

Test run: FAILED

Summary: 4 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@evedon
Copy link
Contributor

evedon commented Jul 25, 2019

This PR is superseded by #11093

@mbed-ci
Copy link

mbed-ci commented Jul 25, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@evedon
Copy link
Contributor

evedon commented Jul 30, 2019

This is now obsolete

@evedon evedon closed this Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants