nRF52 SPI had been broken by `Add sleep manager API` PR

[nvlsianpu]

PR: #4912 introduced changes which somehow broke the SPI for NRF targets. Cl test sheilld test test-api-spi hangs on the case 'SPI - SD card exists' (which is the first with real communication process).

I have tested that even in case I force device to not going to sleep (I mocking hal sleep function by empty one) the test was still hanging. So looks like it is not related to introduced sleep management but rather to RTX changes.

Target
NRF52_DK. NRF52840_DK

Toolchain:
GCC_ARM (maybe others as well)

mbed-os rev
Bug have been reproducing since rev cb4e9b3

ci-test-shield
d1d016383e5776c7b0dd68736256cd3c4405598c (just master HEAD)

Actual behavior

Steps to reproduce
Run the tests-spi-spi ci-test-shield test.

[0xc0170]

I have tested that even in case I force device to not going to sleep (I mocking hal sleep function by empty one) the test was still hanging. So looks like it is not related to introduced sleep management but rather to RTX changes.

Pinpointed rev cb4e9b3, this does not work , any earlier commit works?

I'll try to reproduce this issue.

[nvlsianpu]

Pinpointed rev cb4e9b3, this does not work , any earlier commit works?

Yes, from this rev. including. Any earlier revision works well.

[0xc0170]

Is this only for NRF52 DK? I can't reproduce on NRF51DK

Taken from https://github.com/ARMmbed/ci-test-shield/blob/master/TESTS/API/SPI/SPI.cpp

#include "mbed.h"
#include "FATFileSystem.h"
#include "SDBlockDevice.h"
#include "mbed_error.h"

// main() runs in its own thread in the OS
int main() {
    int result = 0; 
    SDBlockDevice sd(D11, D12, D13, D10);
    FATFileSystem fs("sd");
    sd.init();

    result = fs.mount(&sd);
    if (result !=0) {
        error("SD file system mount failed.\r\n");
    }
    
    FILE *File = fopen("/sd/card-present.txt", "w+");
    
    if (File == NULL) {
        error("SD Card is not present. Please insert an SD Card.\r\n");
    }
    
    result = fs.unmount();
    if (result !=0) {
        error("SD file system unmount failed.\r\n");
    }

    sd.deinit();
}

latest mbed-os master. I do not see how this test can be affected by sleep manager addition (there is no sleep involved as you noted above, it does not affect the code).

[nvlsianpu]

Fortunately NRF51 works well. You need a nrf52 device.

[0xc0170]

Fortunately NRF51 works well. You need a nrf52 device.

These 2 devices do not share the common HAL port? https://github.com/ARMmbed/mbed-os/tree/master/targets/TARGET_NORDIC/TARGET_NRF5 - there are only few differencies. I am failing to see how that commit referenced above can affect SD card test.

I dont have nrf52 currently. @pan- could you help?

[0xc0170]

cc @scartmell-arm - I recall the bug report related to this, Could you rerun the example above or the test, and find out the root cause?

[screamerbg]

Bump @scartmell-arm

[screamerbg]

Bump @0xc0170 @scartmell-arm
CC @MarceloSalazar @dlfryar @maclobdell

I've tested this with 2 different NRF52 boards so far but I get the same TIMEOUT failure that's unrelated to this issue, both before and after the changeset that was mentioned.

[0xc0170]

I got finally the board few days ago, also having TIMEOUT for simple lp ticker test on the latest mbed-os. Using the firmware that is published on mbedos target page (219 version). Anything else missing?

[nvlsianpu]

Is it possible that you try to run the test form hand: you can use RelaTerm witch two subsequent string for start the on-board test: 1st:mbedmbedmbedmbedmbedmbedmbedmbedmbedmbed
2nd: {{__sync;1a2cdb58-88d8-4c5f-8db4-0d4609576611}} ?

this will help to check wheter timeout is caused by IF or mbed-os.