Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with SFDP parsing of the Sector Map Parameter Header and Table parsing #11722

Closed
miteshdedhia7 opened this issue Oct 21, 2019 · 7 comments · Fixed by #12270
Closed

Issues with SFDP parsing of the Sector Map Parameter Header and Table parsing #11722

miteshdedhia7 opened this issue Oct 21, 2019 · 7 comments · Fixed by #12270
Labels
devices: cypress priority: high type: bug

Comments

@miteshdedhia7
Copy link

miteshdedhia7 commented Oct 21, 2019 •
edited
Loading

Description

The QSPIFBlockDevice and potentially the SPIFBlockDevice implementation has the following issues,
Commit: fe12608 (HEAD -> master, origin/master) Merge pull request #11444 from jeromecoutant/PR_QSPI_EXTERNAL
Toolchain: All toolchains
Spec Link: JESD216

  • BUG: In QSPIFBlockDevice.cpp, in _sfdp_parse_sfdp_headers() function on line 787 param_header[0] == 81, the check needs to check for 0x81 (hex) instead of 81 (dec).
    Spec Reference: JESD216 pg 54 section 6.5.1

Issue request type

[ ] Question
[ ] Enhancement
[x] Bug
@miteshdedhia7 miteshdedhia7 mentioned this issue Oct 21, 2019
Merged
miteshdedhia7 pushed a commit to miteshdedhia7/mbed-os that referenced this issue Oct 21, 2019
@cy-opm @cypress-midd
Added CYW9P62S1_43012EVB_01 board
ecdbdc0 
Notes:
- CRC and TRNG are disabled on this board since the MCU on this board does not have the required hardware.
- QSPI and QSPIF are temporarily removed due to issues related to supporting the new S25FS512S flash chip we have on this board. These will be enabled as soon as we can get the issues resolved.
ARMmbed#11722
@ciarmcom
Copy link
Member

Internal Jira reference: https://jira.arm.com/browse/MBOCUSTRIA-1940

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 22, 2019

cc @ARMmbed/mbed-os-storage

@ifyall
Copy link

ifyall commented Nov 15, 2019

@maclobdell Cypress will have one board that will be released publicly at the beginning of 2020 that is impacted by this defect. The impact is that we can't use QSPIBlockDevice with this device as the SFDP results for it are not parsed correctly.

Thank you,

Ian

adbridge pushed a commit that referenced this issue Nov 19, 2019
@cy-opm @adbridge
Added CYW9P62S1_43012EVB_01 board Notes: - CRC and TRNG are disabled …
c4ac78b 
…on this board since the MCU on this board does not have the required hardware. - QSPI and QSPIF are temporarily removed due to issues related to supporting the new S25FS512S flash chip we have on this board. These will be enabled as soon as we can get the issues resolved. #11722
@maclobdell
Copy link
Contributor

@ARMmbed/mbed-os-storage - Please review and make a suggestion.

@VeijoPesonen VeijoPesonen mentioned this issue Jan 16, 2020
Merged
@VeijoPesonen
Copy link
Contributor

@miteshdedhia7 would you please split the bugs as their own issues. The first bug is fixed by the PR #12270

This was referenced Mar 4, 2020
Closed
Closed
@miteshdedhia7
Copy link
Author

Created issues #12574 #12575 for the other two issues. Updated the information on this ticket with just the header parsing issue.

@VeijoPesonen
Copy link
Contributor

VeijoPesonen commented Apr 17, 2020 •
edited
Loading

Fixed by #12270. I would close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devices: cypress priority: high type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUGFIX: SFDP Sector Map Table Parameter ID LSB is 0x81
6 participants
@0xc0170 @maclobdell @ciarmcom @VeijoPesonen @ifyall @miteshdedhia7