Mm platform #22
Mm platform #22
Conversation
| @@ -23,7 +23,7 @@ You will also need to supply the driver for the EEPROM. This example is known to | |||
| Clone the repository containing the collection of examples: | |||
|
|
|||
| ``` | |||
| git clone https://github.com/ARMmbed/mbed-os-example-nfc.git | |||
| git clone https://github.com/vince-zeng/mbed-os-example-nfc.git | |||
There was a problem hiding this comment.
Hmm, didn't mean to change this
| @@ -54,6 +54,11 @@ Run the build: | |||
| mbed compile -t <ARM | GCC_ARM> -m <YOUR_TARGET> | |||
| ``` | |||
|
|
|||
| For NXP K64F, run the following command: | |||
There was a problem hiding this comment.
Not required, it is documented above. We try to not favour a platform.
| @@ -0,0 +1,343 @@ | |||
| /* | |||
There was a problem hiding this comment.
It doesn't seem right to have that file in that PR. PinNames.h should be provided by the mbed os target.
There was a problem hiding this comment.
this is custom target not meant to be in mbed-os
| @@ -0,0 +1,23 @@ | |||
| // The 'features' section in 'target.json' is now used to create the device's hardware preprocessor switches. | |||
There was a problem hiding this comment.
Same as above; you should add the target to mbed-os; not here.
| @@ -13,7 +13,7 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| #include "mbed.h" | |||
There was a problem hiding this comment.
No, avoid to include mbed.h directly as it pulls out a lot of includes and pollute the global namespace with its using namespace std an using namespace mbed statements.
If you need something specific. Include it and import it in the local namespace (if your in a cpp file) if you want shorter names.
#include "Drivers/DigitalIOut.h"
using mbed::DigitalOut;| @@ -37,6 +37,16 @@ using mbed::nfc::ndef::common::span_from_cstr; | |||
| /* URL that will be written into the tag */ | |||
| const char url_string[] = "mbed.com"; | |||
|
|
|||
| #ifdef TARGET_MM | |||
There was a problem hiding this comment.
No, this has nothing to do in the main file. Hide these details in specific target code.
| @@ -1,8 +1,13 @@ | |||
| { | |||
| "macros": ["NFC_I2C_SDA=D14","NFC_I2C_SCL=D15","NFC_FIELD_DETECTION=D5" | |||
There was a problem hiding this comment.
That is specific to a certain config; please add it to the K64F configuration and not the global configuration.
| @@ -0,0 +1,34 @@ | |||
| { | |||
| @@ -0,0 +1 @@ | |||
| https://github.com/ARMmbed/mbed-nfc-nt3h2111 | |||
There was a problem hiding this comment.
Could you specify the hash to load ?
| @@ -0,0 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
Forgot that one; it should be removed from this PR as well.
|
I will remove this PR. This wasn't the right place for it. |
New hw platform