This repository was archived by the owner on Apr 24, 2019. It is now read-only.
Remove config from MACROS.txt #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can do this now, but needs proper testing and documentation updates. Needs corresponding PR in mbed-mesh-api. |
|
Remaining things in MACROS.txt are the switch to enable mbed-trace, and the URI selection. They should be removable too. @jupe |
|
Yeah, default trace 'configs' should be enough for this kind of apps.. Of course user can overwrite if he want but normal use case it shouldnt be needed.. |
|
+1 |
Configuration is now in mbed-mesh-api's mbed_lib.json. If the application wants to override, it can do so by creating an mbed_app.json. (Do we want the application to have an mbed_app.json in place? Or let it use the mbed mesh API defaults?)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration is now in mbed-mesh-api's mbed_lib.json. If the application
wants to override, it can do so by creating an mbed_app.json.
(Do we want the application to have an mbed_app.json in place? Or let
it use the mbed mesh API defaults?)