Skip to content

Make test suites compatible with #include <assert.h> #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2019
Merged

Make test suites compatible with #include <assert.h> #148

merged 1 commit into from
Jun 14, 2019

Conversation

gilles-peskine-arm
Copy link
Collaborator

@gilles-peskine-arm gilles-peskine-arm commented Jun 13, 2019 •
edited
Loading

This is harmless but useless in itself, but needs to be applied to the crypto submodule before Mbed-TLS/mbedtls#2697 can be merged.

@gilles-peskine-arm
Make test suites compatible with #include <assert.h>
9e23bea 
Don't use the macro name assert. It's technically permitted as long as
<assert.h> is not included, but it's fragile, because it means the
code and any header that it includes must not include <assert.h>.
@gilles-peskine-arm gilles-peskine-arm added enhancement New feature or request needs: review The pull request is ready for review. This generally means that it has no known issues. labels Jun 13, 2019
This was referenced Jun 13, 2019
Merged
Merged
Patater
Patater approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Patater
Copy link
Contributor

Patater commented Jun 14, 2019

Merge testing failed with known flaky DTLS test m->m dtls1_2,no TLS-DHE-PSK-WITH-AES-256-GCM-SHA384 .................... FAIL. Head testing was OK.

@Patater Patater merged commit 86268e1 into development Jun 14, 2019
@Patater Patater removed the needs: review The pull request is ready for review. This generally means that it has no known issues. label Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@yanesca yanesca yanesca approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilles-peskine-arm @Patater @yanesca