Pass handle parameter last on key creation #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In psa_generate_derived_key, change the order of parameters to pass the pointer where the newly created handle will be stored last. This is consistent with most other library functions that put inputs before outputs.
gilles-peskine-arm
added
enhancement
psa_import_key now takes an attribute structure, not a type.
In psa_import_key, change the order of parameters to pass the pointer where the newly created handle will be stored last. This is consistent with most other library functions that put inputs before outputs.
gilles-peskine-arm
force-pushed
the
psa-handle-param-order
branch
from
22b95ed to
049c753
Compare
yanesca
approved these changes
May 16, 2019
yanesca
removed
the
needs: review
|
|
|
CI failures on API branch are to do with building with crypto as a submodule and also TLS using PSA, both of which we don't care about at this point in development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the order of parameters for
psa_import_keyandpsa_generate_derived_keyto pass the handle output parameter last. This makes the order consistent with the general convention in the library to put inputs before outputs. Other key handle creation functions (psa_open_key,psa_generate_random_key,psa_copy_key) already had the handle output parameter last.