-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policy usage flag to copy a key #108
Merged
Patater
merged 5 commits into
ARMmbed:psa-api-1.0-beta
from
gilles-peskine-arm:psa-copy_key-policy
May 16, 2019
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4318dfc
psa_export_key, psa_export_public_key: document the EXPORT flag
gilles-peskine-arm 8e0206a
New usage flag PSA_KEY_USAGE_COPY
gilles-peskine-arm f9f4a48
Update psa_copy_key tests to use PSA_KEY_USAGE_COPY
gilles-peskine-arm c160d9e
psa_copy_key: enforce PSA_KEY_USAGE_COPY
gilles-peskine-arm d6a8f5f
Improve description of PSA_KEY_USAGE_COPY
gilles-peskine-arm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1459,6 +1459,20 @@ | |
*/ | ||
#define PSA_KEY_USAGE_EXPORT ((psa_key_usage_t)0x00000001) | ||
|
||
/** Whether the key may be copied. | ||
* | ||
* This flag allows the use of psa_crypto_copy() to make a copy of the key | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. psa_copy_key() |
||
* with the same policy or a more restrictive policy. | ||
* | ||
* For some lifetimes, copying a key also requires the usage flag | ||
* #PSA_KEY_USAGE_EXPORT, because otherwise the source key | ||
* is locked inside a secure processing environment and cannot be | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarify use case? - as above |
||
* extracted. For keys with the lifetime #PSA_KEY_LIFETIME_VOLATILE or | ||
* #PSA_KEY_LIFETIME_PERSISTENT, the usage flag #PSA_KEY_USAGE_COPY | ||
* is sufficient to permit the copy. | ||
*/ | ||
#define PSA_KEY_USAGE_COPY ((psa_key_usage_t)0x00000002) | ||
|
||
/** Whether the key may be used to encrypt a message. | ||
* | ||
* This flag allows the key to be used for a symmetric encryption operation, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording isn't completely clear, for example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the documentation.