Add Sara-N host test hooks. #134
Conversation
|
@bridadan any comment? |
bridadan
left a comment
bridadan
left a comment
There was a problem hiding this comment.
Sorry for the delay! Just a few questions, please see below.
| '-c', | ||
| 'A', | ||
| '-s', | ||
| '0xD7000', |
There was a problem hiding this comment.
Can you clarify a bit what these numbers are? Are they specific for a board? Are they generic?
There was a problem hiding this comment.
They are specific to a board but today we only have one board that requires such test hooks (the SARA_NBIOT_EVK target). I didn't want to add any unnecessary complication by introducing some form of board switch in there.
There was a problem hiding this comment.
Thanks for the clarification. Can you also comment on FlashErase.exe? Is this part of JLink or another program?
There was a problem hiding this comment.
FlashErase.exe is another of the proprietary files, not part of JLink but used to load code onto the target.
| # JLINK.exe --CommanderScript aCommandFile | ||
| cmd = [self.JLINK, | ||
| '-CommanderScript', | ||
| r'reset.jlink'] |
There was a problem hiding this comment.
I'm not that familiar with JLINK. Is reset.jlink a file? Does it need to be in your working directory?
There was a problem hiding this comment.
Yes, there are a few proprietary files required to actually do the download/reset given these hooks. We only need the hooks in here though, the proprietary files themselves can be provided separately.
There was a problem hiding this comment.
@RobMeades Can you please add description for these files in README.
There was a problem hiding this comment.
@mazimkhan certainly; is there a section of the readme where such hook files are usually described, or shall I just create something in there of my own?
There was a problem hiding this comment.
Good question actually. We are certainly missing a section for plugins. Please create a new section "Plugins" and under it a section for SARA_NBIOT_EVK to put the information. We will try to polish it exiting plugins.
bridadan
left a comment
bridadan
left a comment
There was a problem hiding this comment.
LGTM. At some point it'll be worth revisiting how we handle board specific data that needs to be used by htrun and other tools. Ideally this would be stored in the mbed-os repo and used by the tools. There's already the beginnings of this capability in Greentea, however there needs to be a better mechanism of passing this data to htrun.
|
Thanks @bridadan . Any idea when a merge might be possible? |
|
@mazimkhan ping! |
|
@RobMeades I thought you were going to put the documentation in a new section. |
|
Apologies @mazimkhan, I was distracted by other things, I will take a look tomorrow. |
|
no worries 👍 |
|
@mazimkhan: |
bridadan
left a comment
bridadan
left a comment
There was a problem hiding this comment.
Please see my comment below
README.md
Outdated
|
|
||
| Once your mbed tests have been compiled, they may be executed with: | ||
|
|
||
| `python RunTests.py` |
There was a problem hiding this comment.
What is RunTests.py? Is this script necessary to run these tests with htrun? Is it basically a stand-in for greentea? If so, then it seems like this documentation shouldn't be in htrun. I would instead just include the details about the plugin itself, not about how to run a suite of tests (as this outside of the scope of htrun any way)
There was a problem hiding this comment.
Oops, sorry, yes, well spotted, I documented more stuff than is actually submitted here. Will update in a moment...
bridadan
left a comment
bridadan
left a comment
There was a problem hiding this comment.
Thanks for the changes! LGTM
|
@mazimkhan How come travis didn't run on this PR? |
|
no idea. need to check. |
README.md
Outdated
|
|
||
| Once your mbed tests have been compiled, they may be executed with: | ||
|
|
||
| `python RunTests.py` |
There was a problem hiding this comment.
What is RunTests.py? Is it something internal?
I was expecting description about files like FlashErase.exe and reset.jlink.
3 participants
After merge of
mbed-ospull request 3011 , this pull request adds the necessary hook files to usehtruntests on theSARA_NBIOT_EVKtarget (since the target does not currently include a magic chip).