Skip to content

Chip uses new Mbed #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 10, 2021
Merged

Chip uses new Mbed #179

merged 8 commits into from
Aug 10, 2021

Conversation

tymoteuszblochmobica
Copy link

Problem

Chip uses new Mbed
Quick PR

Change overview

What's in this PR

Testing

How was this tested? (at least one bullet point required)

  • If unit tests were added, how do they cover this issue?
  • If unit tests existed, how were they fixed/modified to prevent this in future?
  • If new unit tests are not added, why not?
  • If integration tests were added, how do they verify this change?
  • If new integration tests are not added, why not?
  • If manually tested, what platforms controller and device platforms were manually tested, and how?
  • If no testing is required, why not?

@tymoteuszblochmobica
Copy link
Author

This is initial. Im going to clean and add lockapp and shell

@tymoteuszblochmobica tymoteuszblochmobica force-pushed the NewMbed branch 3 times, most recently from 44787c9 to d45f6dc Compare June 28, 2021 22:36
@lukgni
Copy link

lukgni commented Jun 29, 2021

I didn't see any change here which modifies mbed-os version to something newer.
Have we already switched to the newer mbed-os version on development branch?

@lukgni
Copy link

lukgni commented Jul 2, 2021

I updated mbed-os branch in third_party directory - it looks like CI is happy now (at least for ours workflows).

Here is some notes (or required steps) for changing/updating submodule branch:

  1. edit manually .gitmodules file
  2. execute git submodule sync (only if submodule url has been changed - we need to synchronize .gitmodules with .git/config in that case)
  3. execute git submodule update --init --remote ./third_party/mbed-os/repo to pull changes
  4. commit changes in .gitmodules and ./third_party/mbed-os/repo

Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but ARMmbed/mbed-os#14847 must be merged first. @ATmobica can you look at the PR and address remaining comments ?

@@ -81,7 +81,7 @@
[submodule "mbed-os"]
path = third_party/mbed-os/repo
url = https://github.com/ARMmbed/mbed-os.git
branch = feature-chip
branch = master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can use it until ARMmbed/mbed-os#14847 has been merged

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work with the code we have now but it won't with what's present upstream.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think we can merge it to the current development but check it again before upstreaming.

Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, worst case, we can extract patch master with the PR, put it in a branch and reference it from here.

@pan- pan- merged commit 652a0bd into development Aug 10, 2021
@ATmobica ATmobica deleted the NewMbed branch October 28, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants