-
Notifications
You must be signed in to change notification settings - Fork 4
Chip uses new Mbed #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chip uses new Mbed #179
Conversation
This is initial. Im going to clean and add lockapp and shell |
44787c9
to
d45f6dc
Compare
I didn't see any change here which modifies mbed-os version to something newer. |
d45f6dc
to
003c79d
Compare
I updated mbed-os branch in third_party directory - it looks like CI is happy now (at least for ours workflows). Here is some notes (or required steps) for changing/updating submodule branch:
|
Fix pigweed app CMakeLists
Remove -Wno-error for mbed pigweed build Remove passing mbed-cy-psoc6-common-network compilation flags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but ARMmbed/mbed-os#14847 must be merged first. @ATmobica can you look at the PR and address remaining comments ?
@@ -81,7 +81,7 @@ | |||
[submodule "mbed-os"] | |||
path = third_party/mbed-os/repo | |||
url = https://github.com/ARMmbed/mbed-os.git | |||
branch = feature-chip | |||
branch = master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can use it until ARMmbed/mbed-os#14847 has been merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work with the code we have now but it won't with what's present upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I think we can merge it to the current development but check it again before upstreaming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, worst case, we can extract patch master with the PR, put it in a branch and reference it from here.
Problem
Chip uses new Mbed
Quick PR
Change overview
What's in this PR
Testing
How was this tested? (at least one bullet point required)