[CMake] Ensure link_directories is invoked early enough. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation at https://cmake.org/cmake/help/latest/command/link_directories.html explicitely states : The command will apply only to targets created after it is called, so fix the invocation order in the CMakeLists.txt. While being there, remove the 'PRIVATE' keyword which does not apply to this flavour of the linker command setup. This does fix building tarmac-gui-browser on Mac and remove spurious warnings about non-existing xyz/PRIVATE directories.
statham-arm
added a commit
that referenced
this pull request
Jan 26, 2024
The '--compare' option to test-driver.py takes two arguments indicating things to diff (either files, or the standard output of the command under test), and diffs them the obvious way round, that is, with input #1 shown on the '-' side of the unified diff syntax and input #2 on the '+' side. When the diff is showing the discrepancy between a program's expected and real output, I think it's generally sensible to show the real output on the '+' side, and the expected output as '-'. That convention matches, for example, what you'd get if you had the true output committed in source control and ran 'git diff' or similar to show how the rewritten version differed. But all the comparisons in tests/CMakeLists.txt were written backwards, so the convention was opposite. And I just scratched my head for 20 minutes over a test failure, because I assumed the convention in the previous paragraph, and was trying to figure out how the source code I was looking at could possibly produce the text on the '+' side of the diff! But it hadn't: it had produced the '-' side instead. Reversed all the comparisons so that they make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation at
https://cmake.org/cmake/help/latest/command/link_directories.html
explicitely states :
The command will apply only to targets created after it is called, so
fix the invocation order in the CMakeLists.txt.
While being there, remove the 'PRIVATE' keyword which does not apply to
this flavour of the linker command setup.
This does fix building tarmac-gui-browser on Mac and remove spurious
warnings about non-existing xyz/PRIVATE directories.