Reserve relocation codes for PAuthABI #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Alpha PAuthABI defines a small number of static and dynamic relocations in the private vendor experiment space. When an upstream implementation lands we will want to use non-experimental codes. Step 1 is to reserve a range of static and dynamic relocations in AAELF64 so we can guarantee no clash with any relocations defined in the PAuthABI.
stuij
reviewed
May 20, 2021
| PAuthABI relocations | ||
| ^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| The PAuthABI relocations are currently defined in the vendor experiment space. Arm reserves codes 580 to 600 for static PAuthABI relocations and 1040 - 1060 for dynamic PAuthABI relocations. |
There was a problem hiding this comment.
I've got no issues with the reserved ranges. But perhaps reword the paragraph slightly to indicate that the plan is to migrate the relocations currently defined in the vendor experiment stage to the reserved ranges. As it's phrased now it's not totally clear to me how the two sentences relate to each other.
|
Thanks for the comments, I've abandoned this in favour of #100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Alpha PAuthABI defines a small number of static and dynamic relocations
in the private vendor experiment space. When an upstream implementation
lands we will want to use non-experimental codes. Step 1 is to reserve
a range of static and dynamic relocations in AAELF64 so we can guarantee
no clash with any relocations defined in the PAuthABI.