Fix mixed value type decoding in sds-convert - #304
Open
ricardoasouz wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ricardo Alves de Souza <ricardoasouz@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #271
The original IndexError reported in #271 is no longer reproducible on the current main branch, but the remaining mixed-type conversion issue persists.
When a record contains values with different sizes, such as:
The current decoder processes each channel independently, assuming a uniform stride. This causes the byte stream to become misaligned across channels.
For example, the SDS data referenced in #271 decodes correctly as:
For example, the SDS data referenced in #271 decodes correctly as:
while the current converter produces:
This change decodes each complete sample using the combined metadata format, then distributes the decoded values to the corresponding channels. Standard-size packing is used without native alignment padding.
Validation: