Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when building DSP library #1130

Closed
Gostas opened this issue Feb 18, 2021 · 4 comments
Closed

Error when building DSP library #1130

Gostas opened this issue Feb 18, 2021 · 4 comments

Comments

@Gostas
Copy link

Gostas commented Feb 18, 2021

I am trying to build the DSP library for the cortex-m4 cpu. The compiler I am using is arm-none-eabi-gcc 9.2.1 (9-2019-q4-0ubuntu1). After running make VERBOSE=1, I am getting the following error:

/home/kpaps/Documents/CMSIS_5/CMSIS/DSP/Source/TransformFunctions/arm_cfft_radix4_init_f16.c:70:3: error: unknown type name 'arm_cfft_radix4_instance_f16' 70 | arm_cfft_radix4_instance_f16 * S,

@christophe0606
Copy link
Contributor

@Gostas f16 is not always well supported depending on the core / compiler so there is some logic to enable / disable it.

But it looks like this logic is missing in arm_cfft_radix4_init_f16.c.

There should be a test on ARM_FLOAT16_SUPPORTED with #if/#else to disable or enable the compilation.

This flag is disabled in your compilation so the instance structure and tables for this f16 algorithm are not compiled but the function is compiled although it should not.

Note that:

  • radix4 is deprecated. But we understand people are still using it ;
  • If you don't need f16 (and it is only useful when there is some HW acceleration for f16 which is not the case on M4) you may remove the f16 files from the build

@christophe0606 christophe0606 added bug and removed review labels Feb 19, 2021
@Gostas
Copy link
Author

Gostas commented Feb 19, 2021

Thanks for the explanation @christophe0606 . I added the guard condition in arm_cfft_radix4_init_f16.c and was able to get it to build, because I wasn't sure how to remove the f16 files from the build.

christophe0606 added a commit that referenced this issue Feb 19, 2021
Better control of the f16 build.
@christophe0606
Copy link
Contributor

@Gostas I have just pushed 9f52415 which should solve the issue.

@Gostas
Copy link
Author

Gostas commented Feb 19, 2021

Great, thanks!

@Gostas Gostas closed this as completed Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants