Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-wallet-api): initial implementation #2544

Merged
merged 2 commits into from
May 8, 2019
Merged

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented May 8, 2019

Summary

Initial implementation of the planned Wallet API due to the fact that the wallet relied on a P2P Endpoint which no longer exists in 2.4.0.

What kind of change does this PR introduce?

  • Bugfix
  • New feature
  • Refactoring / Performance Improvements
  • Build-related changes
  • Documentation
  • Tests / Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ghost
Copy link

ghost commented May 8, 2019

The ci/circleci: test-node10-e2e job is failing as of 38596b35edf5ceb8264ef044217be25d861403bd. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian merged commit d3af2e9 into develop May 8, 2019
@ghost ghost deleted the feat/wallet-api branch May 8, 2019 06:21
vasild added a commit that referenced this pull request May 8, 2019
…legate-resignation

* ArkEcosystem/core/develop:
  chore(deps): update and remove unused dependencies (#2546)
  release: 2.4.0-next.2 (#2545)
  feat(core-wallet-api): initial implementation (#2544)
  fix(core): use the --env flag to start testnet via CLI (#2543)
  release: 2.4.0-next.1 (#2541)
  refactor(core-database-postgres): transaction type agnostic wallet bootstrap (#2539)
  release: 2.4.0-next.0 (#2540)
  refactor(core): let the process manager extend @faustbrian/foreman (#2536)
  feat: Implement IPFS (AIP11) (#2537)
@spkjp spkjp mentioned this pull request May 9, 2019
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant